Remove subgroups #799
Merged
Remove subgroups #799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesseAbram
added a commit
that referenced
this pull request
Jul 16, 2024
* Remove subgroups (#799) * remove subgroups * pallet tests working * fix benchmarks * tests working * clean * clean * remove unwrap * add check balance check to launch * fix test * fix inital chainstate * clean tests * changelog * fmt * fix * fix * remove permission from chain (#801) * remove permission from chain * update chainspec * remove permissioned from tss * clean * clean tests * remove commented out code * wasm test * lint * lint * lint * fixes * Remove sig party size (#817) * Remove sig party size * clean * lint * fixes * fmt * fix wasm build * fix * Bump synedrion to unreleased git version ahead of adding t-of-n in Migrate-To-Threshold branch (#851) * Bump synedrion to unreleased git version * Bump synedrion again and update execute_protocol.rs for new API * Update kvdb for new synedrion API * Update entropy-tss for new synedrion api * Clippy * Fix entropy-protocol for wasm target * Clippy * Fixes for testing-utils * Fixes for entropy-tss tests * Fixes for entropy-protocol tests * Fixes for entropy-protocol tests * Keep shares as ThresholdKeyShare until the point of using them in the signing protcol * Dont use a fixed threshold for the reshare protocol * Update entropy-tss for storing ThresholdKeyShares * Update entropy-testing-utils for storing ThresholdKeyShares * Clippy * Clippy * Fixes for testing * Little refactor of protocol tests * Rm dave from proactive refresh genesis block just to see if things work * Type alias for keyshare payload * Fix entropy-tss tests to use DAVE as well as EVE when testing proactive refresh * Update DAVEs constants * Use type alias for keyshare payload * Put chainspec back to how it was originally * Tidy * Tidy * Rm unused imports * t of n key generation and signing at the `entropy-protocol` level (#868) * Update our DKG protocol to internally run key init, reshare, and auxgen * Allow threshold to be passed into DKG fn * Update entropy-tss for new DKG api * Try various things to figure out why the tests pass locally but not in CI * Rm logging * Update for full t of n signing test * Lockfile * Update signing client protocol execution * Run tests in serial * Taplo * Clippy * Error handling when selecting DKG committee * Error handling for DKG protocols * Logging * Comments * Error handling for DKG protocols * Always run t-of-n test with minimum 3 parties even when running with only 2 cores * Only run t of n test with 3 parties * Rm comment * Rm panic * Typo Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Improve doccomment Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Fix typo * Rename enum for protocol message payload * Add threshold to logged fields in tracing macro * Final changes from doccomments --------- Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Pregenerated threshold keyshare set for `entropy-tss` tests (#884) * Make unsafe fns for resharing centralized keyshares for tests * Make pairwrapper public * Make test keyshare fn * Make test keyshares in testing-utils * Add script for creating test shares * Add main fn for creating keyshares and add keyshares * Use test params for test keyshares * Update keyshares with test params * Rm make_centralized test * Rm unused fns from execute_protocol.rs * Changelog * Clippy * Mv synedrion test environment stuff to a module of its own * Mv create keyshares to separate crate * Add create test keyshares crate to cargo-deny exceptions list * Use t of n signing in `entropy-tss` (#879) * Add test helper fn for setting up 3 tss nodes * Update integratiion test chain spec * Add charlie keys to testing utils constants * Attempt a test for dkg with 3 validators * Add charlie to the correct chain spec - dev not integration_tests * Make full test including signing, sort party ids, and make nonce call at the point of finishing dkg * Sort party ids * Attempt to run test with longer delay when waiting for register confirmation * Set threshold to a fixed proportion of the number of validators * Deduplicate get_signers_from_chain fn * Rename test * Update store_share test * Onchain user request in test must be mutable * Comment out failing tests (temporary) * Sort party ids, and extend timeout in store_share test * Sort party ids after getting subset for key init protocol * Sort party ids before truncating for signing * Extend timeout for store share test yet again * Add EVE keyshares to kvdbs when setting up testing validators * Create test keyshares should run aux gen session and be generic for scheme params * Script should use mnemonics for default TSS nodes * Update keyshares, move spawn validator fn outside of entropy-tss so it can be used for integration tests * Rm moved fn from test helpers * entropy-tss sign integration test uses pre-generated keyshares * Fix how sr25519 keypairs are created from mnemonic * Expose get_signer_and_x25519_secret_from_mnemonic fn without cfg(test) * Have both production and test keyshare sets, only one spawn_testing_validators fn * Have both production and test keyshare sets in create test keyshares script * Update tests * WIP deserialize verifying key fn * Basic no_chain test passing * Move spawn_testing_validators back to entropy-tss and fix tests * Rm tss_server_process module from testing-utils * Update decode_verifying_key fn with error handling * Clippy * Doccomments * Uncomment cfg * Rm logging * Helper fn does not need to be public * Test helper should only be available when feature is active or test mode * Rm logging * Rm unused dependency * Rm comment * Fix device key proxy test * Add dave keyshares and fix proactive reshare test * Clippy * Refactor unsafe_get helper * Clippy * Send session id hash in protocol message so that we can check it * temporary comment out negative test from share_store * Clippy, logging * Improve test helper fn * Fix sign_eth_tx test * Fix test helper * Put messages destined for another session back into the incoming message queue * Uncomment commented out bit of store share test * Doccomments * Use centralized aux gen protocol when creating test keyshares * Comments, logging * Tidy test helper fn * Revert changes to timeouts in store share test * Rm unwrap * Rm duplicate test * Add link to issue to TODO * Use enum to represent DKG sub-session * Comment in cargo toml * Comments explaining how keys are derived * Change eve to dave in signing tests * Change eve to dave in signing tests * Taplo * Doccomments * Add charlie to integration test chainspec * Proactive refresh should use threshold from keyshare * Set the old threshold to n but keep the new threshold as t when resharing * update to master * merge fixes * fix wasm test * remove todo * Missed a merge item * Remove subgroups from jumpstart (#936) * Remove subgroups from jumpstart code * Bump metadata * Remove subgroup from TSS call * Try and update benches * fix failing benchmark * Get tests compiling * Remove tests related to key syncing * Add check that validator is actually in set and not just a candidate * Remove commented code * Appease Clippy * Remove commented code * Add third validator to jumpstart tests * Remove `KeyVisiblity` from registry tests * Switch to `KeyShareWithAuxInfo` * Don't use with `WithAuxInfo` variant * Add validators to benchmark validator set * Add ID of validator which confirmed jump start to event * Fix some formatting * add aux info back into key * fix jumpstart test --------- Co-authored-by: Jesse Abramowitz <jesse@entropy.xyz> --------- Co-authored-by: peg <peg@magmacollective.org> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> Co-authored-by: Hernando Castano <hernando@hcastano.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes subgroups from our codebase to prep for Migrating to Threshold Signing