Improve test CLI following removing permissioned mode #770
Conversation
| @@ -190,7 +190,7 @@ async fn test_sign_tx_no_chain() { | |||
| update_programs( | |||
| &entropy_api, | |||
| &rpc, | |||
| DAVE_VERIFYING_KEY.to_vec(), | |||
| DAVE_VERIFYING_KEY.to_vec().try_into().unwrap(), | |||
There was a problem hiding this comment.
This would not be needed if we made these constants be a [u8; 33]
There was a problem hiding this comment.
Should be an easy change, no? Or does that introduce too much noise into the PR?
| @@ -23,6 +23,8 @@ pub use synedrion::KeyShare; | |||
|
|
|||
| use std::time::SystemTime; | |||
|
|
|||
| pub const VERIFYING_KEY_LENGTH: usize = entropy_shared::VERIFICATION_KEY_LENGTH as usize; | |||
There was a problem hiding this comment.
Why re-export this instead of using the one from entropy_shared?
There was a problem hiding this comment.
Because i need a usize and in entropy_shared its a u32 or something. I am unsure about about making it a usize there because of potential issues with usize being different on wasm.
There was a problem hiding this comment.
actually maybe it will be fine, lets try....
| @@ -190,7 +190,7 @@ async fn test_sign_tx_no_chain() { | |||
| update_programs( | |||
| &entropy_api, | |||
| &rpc, | |||
| DAVE_VERIFYING_KEY.to_vec(), | |||
| DAVE_VERIFYING_KEY.to_vec().try_into().unwrap(), | |||
There was a problem hiding this comment.
Should be an easy change, no? Or does that introduce too much noise into the PR?
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
As discussed in #666 there was some small fixes needed to the test CLI. I got stuck on this today because i was trying to use the test CLI, and it was only showing the first 32 bytes of verifying keys (they are 33 bytes).
I have changed the test client to take verifying keys as
[u8; 33]rather thanVec<u8>to ensure they are the right size. Ideally we should have a type for a serialized verifying key, but thats a bigger PR.