Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pallet-free-tx #662

Merged
merged 11 commits into from
Mar 7, 2024
Merged

Remove pallet-free-tx #662

merged 11 commits into from
Mar 7, 2024

Conversation

HCastano
Copy link
Collaborator

@HCastano HCastano commented Mar 7, 2024

This isn't used anymore, so let's just remove the code. If we ever decide to use
it again we can pull in back in from version control

@HCastano HCastano added Bump `spec_version` A change which affects the current runtime behaviour Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes) labels Mar 7, 2024
Copy link

vercel bot commented Mar 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 7, 2024 10:51pm

Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good move - agree it good not to have dead code lying around - although not sure if anyone is planning to do something with this soon.

This pallet is also mentioned in the docs - i guess i'll also remove it there:
https://github.com/entropyxyz/entropy-docs/blob/93e7a4431a6bbf2757081b593e21fc1d6e2b8b02/docs/03-Validators.md?plain=1#L33

@HCastano HCastano merged commit 7201eb7 into master Mar 7, 2024
10 checks passed
@HCastano HCastano deleted the hc/remove-free-tx-pallet branch March 7, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bump `spec_version` A change which affects the current runtime behaviour Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants