Add version number to registered #658
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JesseAbram
changed the title
HCastano
approved these changes
Mar 5, 2024
CHANGELOG.md
Outdated
| @@ -20,11 +20,12 @@ At the moment this project **does not** adhere to | |||
| `StakingExtensionConfigproactive_refresh_data` and takes a tuple of `Vec`. Both should be empty at | |||
| genesis for production. | |||
| - In [#631](https://github.com/entropyxyz/entropy-core/pull/631), the `config_interface` field of `ProgramInfo` was renamed to `interface_description` to be more semantically accurate. This field will now be used to describe program interfaces, including the auxilary and configuration interfaces of the program. | |||
| - In [#658](https://github.com/entropyxyz/entropy-core/pull/658), `RegisteredInfo` and `RegisteredInfo` now contain `version_number` | |||
There was a problem hiding this comment.
Suggested change
| - In [#658](https://github.com/entropyxyz/entropy-core/pull/658), `RegisteredInfo` and `RegisteredInfo` now contain `version_number` | |
| - In [#658](https://github.com/entropyxyz/entropy-core/pull/658), `RegisteredInfo` and `RegisteringDetails` now contain `version_number` |
You'll also need to make a note of the new KeyVersionNumber config parameter.
There was a problem hiding this comment.
In the change log? doesn't that not touch outside interactions so should remain off the breaking changes
There was a problem hiding this comment.
@JesseAbram if any external developer were to use our pallet, they would need to know about this
JesseAbram
added
the
Bump `spec_version`
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #646