Rename ProgramInfo.config_interface to interface_description #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JesseAbram
approved these changes
Feb 12, 2024
JesseAbram
requested changes
Feb 12, 2024
Co-authored-by: peg <peg@magmacollective.org>
Co-authored-by: peg <peg@magmacollective.org>
Co-authored-by: peg <peg@magmacollective.org>
|
@JesseAbram i didn't see the spec tag, nice. i updated the changelog too |
HCastano
added
Bump `spec_version`
jakehemmerle
force-pushed
the
rename-config-interface
branch
from
0cb4823 to
222dbd3
Compare
jakehemmerle
force-pushed
the
rename-config-interface
branch
from
222dbd3 to
f849dc2
Compare
|
@JesseAbram can you reapprove? |
JesseAbram
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the
config_interfacefield will be used to describe the interfaces for both the config and for auxiliary data (and future additional and even user-defined interfaces), it makes sense to rename it tointerface_descriptionto reduce ambiguity.