Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Emit events on TSS server errors #625

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Emit events on TSS server errors #625

merged 4 commits into from
Feb 7, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Feb 7, 2024 •
edited
Loading

Loggings on error will now look like this

2024-02-07T17:57:48.171177Z ERROR http-request{uuid=4231bdbd-c116-4d4f-9c28-860e18c5450b uri=/user/new method=POST}: entropy_tss::user::errors: "Invalid Signer: Invalid Signer in Signing group"

Closes #621

@vercel Vercel
Copy link

vercel bot commented Feb 7, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 7, 2024 6:48pm

@JesseAbram JesseAbram marked this pull request as ready for review February 7, 2024 14:50
@HCastano HCastano changed the title Add loggings on error Emit events on TSS server errors Feb 7, 2024
HCastano
HCastano approved these changes Feb 7, 2024
View reviewed changes
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've changed the issue title and PR title to make them more descriptive. Code LGTM 👍

crates/threshold-signature-server/src/signing_client/errors.rs Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
JesseAbram and others added 2 commits February 7, 2024 09:38
@JesseAbram @HCastano
Update CHANGELOG.md
b5581ea 
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
@JesseAbram
refactor
5487d84
ameba23
ameba23 approved these changes Feb 7, 2024
View reviewed changes
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JesseAbram JesseAbram merged commit 2c973a2 into master Feb 7, 2024
10 checks passed
@JesseAbram JesseAbram deleted the logging-on-error branch February 7, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@ameba23 ameba23 ameba23 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve logging on TSS server errors
3 participants
@JesseAbram @ameba23 @HCastano