Add ValidatorSubgroupRotated event
#618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
HCastano
approved these changes
Feb 2, 2024
Comment on lines
+182
to
+186
| let mut current_subgroups: Vec<Vec<<T as pallet_session::Config>::ValidatorId>> = vec![]; | ||
| for signing_group in 0..SIGNING_PARTY_SIZE { | ||
| let current_subgroup = SigningGroups::<T>::get(signing_group as u8).unwrap(); | ||
| current_subgroups.push(current_subgroup) | ||
| }; |
There was a problem hiding this comment.
Why do we need to update the benches in this case?
There was a problem hiding this comment.
2 reasons, one is we test events in benchmarks but the second and worse reason is that john wrote these tests in python and the rust test is gone, imma rewrite the test in rust but that I wanna get this in fast to fix testnet things so made an issue #620
HCastano
changed the title
ValidatorSubgroupRotated event
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
HCastano
reviewed
Feb 2, 2024
CHANGELOG.md
Outdated
| @@ -83,6 +83,7 @@ algorithms are also supported. | |||
| - Add --version flag and about field to TSS ([#590](https://github.com/entropyxyz/entropy-core/pull/590/)) | |||
| - Program config storage ([#593](https://github.com/entropyxyz/entropy-core/pull/593)) | |||
| - Add a hashes endpoint ([#600](https://github.com/entropyxyz/entropy-core/pull/600)) | |||
| - Add ValidatorSubgroupRotated event ([#618](https://github.com/entropyxyz/entropy-core/pull/618)) | |||
There was a problem hiding this comment.
@JesseAbram this needs to go under the [Unreleased] header, no the v0.0.10 one
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add an event to be triggered on session that shows the old subgroup validator groups and the new ones