Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change program_modification_account to deployer #604

Merged
merged 9 commits into from
Jan 24, 2024
Merged

Change program_modification_account to deployer #604

merged 9 commits into from
Jan 24, 2024

Conversation

JesseAbram
Copy link
Member

@JesseAbram JesseAbram commented Jan 23, 2024 •
edited by HCastano
Loading

Closes #599.

@vercel Vercel
Copy link

vercel bot commented Jan 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 0:44am

@JesseAbram JesseAbram changed the title change to program deploy key Change to program deploy key Jan 23, 2024
@JesseAbram JesseAbram marked this pull request as ready for review January 23, 2024 21:40
HCastano
HCastano reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to cover the terminology split that Frankie wants in #599

pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/relayer/src/lib.rs Outdated Show resolved Hide resolved
crates/testing-utils/src/test_client/mod.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Show resolved Hide resolved
crates/test-cli/src/main.rs Outdated Show resolved Hide resolved
@JesseAbram JesseAbram requested a review from HCastano January 23, 2024 22:40
@JesseAbram
Copy link
Member Author

This doesn't seem to cover the terminology split that Frankie wants in #599

got a little over zealous should be good now

@HCastano HCastano changed the title Change to program deploy key Change program_modification_account to program_deploy_key Jan 23, 2024
HCastano
HCastano reviewed Jan 23, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
pallets/programs/src/lib.rs Outdated Show resolved Hide resolved
JesseAbram and others added 2 commits January 23, 2024 15:50
@JesseAbram @HCastano
Update pallets/programs/src/lib.rs
11541af 
Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
@JesseAbram
clean
647919c
HCastano
HCastano approved these changes Jan 24, 2024
View reviewed changes
Copy link
Collaborator

@HCastano HCastano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@HCastano HCastano merged commit e55a0c0 into master Jan 24, 2024
10 checks passed
@HCastano HCastano deleted the change-to-program-deploy-key branch January 24, 2024 01:40
@HCastano HCastano changed the title Change program_modification_account to program_deploy_key Change program_modification_account to deployer Feb 7, 2024
@HCastano HCastano mentioned this pull request Feb 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HCastano HCastano HCastano approved these changes

@ameba23 ameba23 Awaiting requested review from ameba23

@frankiebee frankiebee Awaiting requested review from frankiebee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Differentiate between a program_mod_account and a program_deploy_key
2 participants
@JesseAbram @HCastano