Include contents of x25515chacha20poly1305 repo in entropy-protocol
#563
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ameba23
commented
Dec 15, 2023
| @@ -6,48 +6,48 @@ const protocol = require('entropy-protocol') | |||
|
|
|||
There was a problem hiding this comment.
The edits to this file are from an automated code formatter (standard). This is not related to this PR, but since i put the other JS test through the formatter i thought to be consistent i should do this one as well.
I don't have any particular reason to choose standard, i just had to pick something.
ameba23
commented
Dec 15, 2023
| @@ -0,0 +1,43 @@ | |||
| const protocol = require('entropy-protocol') | |||
There was a problem hiding this comment.
This test isn't just copied over - I added some things. You can see the old test here: https://github.com/entropyxyz/x25519-chacha20poly1305/blob/main/example/test.ts
JesseAbram
approved these changes
Jan 4, 2024
| @@ -21,6 +21,7 @@ At the moment this project **does not** adhere to | |||
|
|
|||
| ### Added | |||
| - Test CLI which calls the same code as in integration tests ([#417](https://github.com/entropyxyz/entropy-core/pull/417)) | |||
| - Include contents of x25515chacha20poly1305 repo in entropy-protocol ([#563](https://github.com/entropyxyz/entropy-core/pull/563)) | |||
There was a problem hiding this comment.
probably should add the camel case thing to breaking
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the contents of
x25519-chacha20poly1305:SignedMessageandderive_static_secret, as well as the wasm bindingssign_and_encryptetc, be part of theentropy-protocolcrate.This means we have one less crate to manage (and publish). But at the expense of making
entropy-protocolmore complex.Once doing this i took the opportunity to change the JS function names to camelCase. This is not considered a breaking change in the changelog, since this API is new here and the other crate still exists.