add custom hashing #553
Merged
add custom hashing #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
db73220 to
bf4b1c9
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
e9ff62f to
cd70ddf
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
2 times, most recently
from
84f064b to
cd6ad60
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
cd6ad60 to
2500583
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
2500583 to
306edf8
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
fff18e6 to
e078c9e
Compare
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
6cd5ab1 to
482b4fa
Compare
JesseAbram
approved these changes
Jan 3, 2024
jakehemmerle
force-pushed
the
add-custom-hashing
branch
from
700c06e to
8e6dba2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds SHA1-3 (256-bit) and Keccak hashes on the core side, and allows for users to implement their own custom hash function (eg Pedersen, BLAKE2) in a Program if they need to.
While this PR includes the appropriate integration test modification, it does not test the hash computing function directly. That will be included in a follow up PR shortly, as described in #572 .
I still need to append the spec addition to the CHANGELOG file, but other than that it should be good to go.SDK related changes @frankiebee @jawndiego :
There is now an additional
hashfield in the/sign_txJSON body that indicates which hashing algorithm to use for signing. The options are: 'sha1', 'sha2', 'sha3', 'keccak', and 'custom' ('custom' indicates a custom hash function is implemented atcustom_hash()on the Program.)