Pointer for programs #536

JesseAbram · 2023-11-28T21:23:40Z

except for a few outlying questions this accomplishes the basics of #531

Done

Breaks up storage of program into program and a user can point to it
allows for removal of programs by person paying deposit

Future

allow for multiple pointers in registered when program linking happens
allow for config info when we can take inputted config changes (like a whitelist where we have the addresses as a config)
Allow governance controlled programs

Discussion

How do we handle removal if people are using (personally I like the idea of use for free but allow multiple ppl to pay and only remove the program if no one is paying for it)

vercel · 2023-11-28T21:23:46Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
entropy-core	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Dec 13, 2023 7:20pm

ameba23 · 2023-11-30T09:00:13Z

I didn't make it to meet and discuss this yesterday so putting my thoughts here.

This looks like exactly what we want. If i've understood right, the new flow for registering with a new program would be to first submit the program, and then submit registration giving the hash pointer.

I'm not sure about 'removing a program' - i don't understand how this works but obviously we don't want to allow removing a program someone else is using.

In order to make this useful i guess we would need to maintain somewhere a list of program hashes and descriptions of what they do.

And for security we would probably want a way of proving the source code associated with a publicly available program. Being able to compile a program deterministically would solve this. I think we already talked about this at some point so i wont blabber on about it here.

Another issue (for later) would be that with, for example, access-control lists, there's currently no way of separating the boilerplate program code from the user-defined part (the list of allowed/blocked addresses).

JesseAbram · 2023-12-01T17:02:49Z

I didn't make it to meet and discuss this yesterday so putting my thoughts here.

This looks like exactly what we want. If i've understood right, the new flow for registering with a new program would be to first submit the program, and then submit registration giving the hash pointer.

yes or even not have to submit the program

I'm not sure about 'removing a program' - i don't understand how this works but obviously we don't want to allow removing a program someone else is using.

ya we had a heated discussion about it, just gonna keep it as it and solve it in SD, a lot of ways to handle it, right now if someone is paying the deposit they should be able to pull it, also having chain controlled ones that don't require a deposit, but still ya kicking this to the retreat

In order to make this useful i guess we would need to maintain somewhere a list of program hashes and descriptions of what they do.

Ya we had the programs store concept which I like but that is for another day

And for security we would probably want a way of proving the source code associated with a publicly available program. Being able to compile a program deterministically would solve this. I think we already talked about this at some point so i wont blabber on about it here.

Had this convo @jakehemmerle made the program compilation deterministic which is fire ask him if you want more details

Another issue (for later) would be that with, for example, access-control lists, there's currently no way of separating the boilerplate program code from the user-defined part (the list of allowed/blocked addresses).

ya in the programs roadmap

…ter-for-programs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

pallets/programs/src/benchmarking.rs

HCastano · 2023-12-12T20:37:47Z

pallets/programs/src/mock.rs

@@ -54,6 +54,7 @@ impl system::Config for Test {
 parameter_types! {
  pub const MaxBytecodeLength: u32 = 3;
  pub const ProgramDepositPerByte: u32 = 5;
+  pub const MaxOwnedPrograms: u32 = 1;


I want to avoid the case where a dev six months down the line spends times trying to figure out why their test of multiple uploaded programs fails for some "mysterious reason"

pallets/relayer/src/lib.rs

crypto/testing-utils/src/constants.rs

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

…ter-for-programs

HCastano

LGTM, thanks for this!

CHANGELOG.md

HCastano · 2023-12-13T18:05:11Z

pallets/relayer/src/tests.rs

@@ -58,44 +56,22 @@ fn it_tests_get_validator_rotation() {
 fn it_registers_a_user() {
    new_test_ext().execute_with(|| {
        let empty_program = vec![];
+        let program_hash = <Test as frame_system::Config>::Hashing::hash(&empty_program);


Ya, this is nicer than before, thanks!

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

* Add more notes around breaking changes in #536 * Be more explicit about breaking changes in `v0.0.10`

JesseAbram added 2 commits November 28, 2023 15:43

update program pallet

c171909

update relayer

7690e9e

JesseAbram requested review from jakehemmerle and HCastano November 28, 2023 21:24

vercel bot deployed to Preview November 28, 2023 23:16 View deployment

programs tests

0ec0232

vercel bot deployed to Preview November 29, 2023 17:31 View deployment

relayer tests

8f45c05

vercel bot deployed to Preview November 29, 2023 20:13 View deployment

test change pointer

40b9be9

vercel bot deployed to Preview November 29, 2023 20:42 View deployment

add program owner

2d825a7

vercel bot deployed to Preview November 30, 2023 16:40 View deployment

update server

6a7ee42

vercel bot deployed to Preview December 1, 2023 17:14 View deployment

HCastano mentioned this pull request Dec 1, 2023

Convert user constraint to Pointer #531

Closed

fix tests

eb66a9f

vercel bot deployed to Preview December 1, 2023 18:45 View deployment

remove program bench

b693792

vercel bot deployed to Preview December 1, 2023 19:49 View deployment

add change pointer benchmark

79d2e66

vercel bot deployed to Preview December 1, 2023 21:10 View deployment

JesseAbram added 3 commits December 1, 2023 18:29

fix test

a1588e7

fix bench

9412b49

clean

78acd5f

vercel bot deployed to Preview December 2, 2023 00:20 View deployment

Merge branch 'master' of github.com:entropyxyz/entropy-core into poin…

0d63f1b

…ter-for-programs

JesseAbram and others added 2 commits December 12, 2023 09:57

Update pallets/programs/src/lib.rs

d2d85c5

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

Update pallets/programs/src/lib.rs

9d91d5c

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

vercel bot had a problem deploying to Preview December 12, 2023 18:20 Failure

JesseAbram added 3 commits December 12, 2023 14:03

refactors

ee05fb5

refactor

ce5ec15

refactor

e1524bd

HCastano reviewed Dec 12, 2023

View reviewed changes

crypto/testing-utils/src/constants.rs Outdated Show resolved Hide resolved

vercel bot deployed to Preview December 12, 2023 21:50 View deployment

JesseAbram and others added 7 commits December 12, 2023 18:14

refactor

0def29c

refactors

bd469f0

clean

3b19fcc

change runtime value

e7038fd

Update pallets/relayer/src/benchmarking.rs

6d42057

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

Apply suggestions from code review

38ebc81

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

fix

b601ed3

vercel bot deployed to Preview December 13, 2023 00:11 View deployment

remove duplicate update_pointer

9e3eb90

JesseAbram requested a review from HCastano December 13, 2023 15:53

Merge branch 'master' of github.com:entropyxyz/entropy-core into poin…

ebbdb55

…ter-for-programs

vercel bot deployed to Preview December 13, 2023 16:37 View deployment

fix benchmarks

886412f

HCastano approved these changes Dec 13, 2023

View reviewed changes

Update CHANGELOG.md

dca6cc2

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>

JesseAbram merged commit fb247ba into master Dec 13, 2023
9 of 10 checks passed

JesseAbram deleted the pointer-for-programs branch December 13, 2023 18:43

vercel bot deployed to Preview December 13, 2023 19:20 View deployment

HCastano added the Bump `spec_version` A change which affects the current runtime behaviour label Jan 23, 2024

HCastano added a commit that referenced this pull request Jan 25, 2024

Add more notes around breaking changes in #536

1f975fe

HCastano added a commit that referenced this pull request Jan 25, 2024

Be more explicit about breaking changes in v0.0.10 (#607)

3288a1a

* Add more notes around breaking changes in #536 * Be more explicit about breaking changes in `v0.0.10`

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Pointer for programs #536

Pointer for programs #536

JesseAbram commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading

ameba23 commented Nov 30, 2023

JesseAbram commented Dec 1, 2023

HCastano Dec 12, 2023

HCastano left a comment

HCastano Dec 13, 2023

Pointer for programs #536

Pointer for programs #536

Conversation

JesseAbram commented Nov 28, 2023 • edited Loading

Done

Future

Discussion

vercel bot commented Nov 28, 2023 • edited Loading

ameba23 commented Nov 30, 2023

JesseAbram commented Dec 1, 2023

HCastano Dec 12, 2023

Choose a reason for hiding this comment

HCastano left a comment

Choose a reason for hiding this comment

HCastano Dec 13, 2023

Choose a reason for hiding this comment

JesseAbram commented Nov 28, 2023 •

edited

Loading

vercel bot commented Nov 28, 2023 •

edited

Loading