Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change REFRESHES_PER_SESSION from u128 to u32 #513

Merged
merged 4 commits into from
Nov 17, 2023

Conversation

HCastano
Copy link
Collaborator

I figured it would be easier to show some code than to go back and forth on GitHub.

Wdyt about this @JesseAbram ?

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
entropy-core ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 4:42pm

@JesseAbram
Copy link
Member

I figured it would be easier to show some code than to go back and forth on GitHub.

Wdyt about this @JesseAbram ?

ya this looks good will merge it in when it passes CI......actually I can just handle that in my branch merging now

@JesseAbram JesseAbram merged commit 5cbaa11 into partition-proactive-refresh Nov 17, 2023
5 checks passed
@JesseAbram JesseAbram deleted the hc-update-types branch November 17, 2023 16:31
JesseAbram added a commit that referenced this pull request Nov 20, 2023
* partition proactive refresh

* finished partitioning algorithim

* refactor

* fmt

* document

* add logger to test

* refactor

* Change `REFRESHES_PER_SESSION` from `u128` to `u32` (#513)

* Change refresh session type to `u32`

* Fix typo

* Remove `Result` return type

* Remove `unwrap`s from test

* move refreshes done to ocw message

* lint

* fix propogation test

---------

Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants