fix typos in readme #276
Merged
fix typos in readme #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current dependencies on/for this PR:
This comment was auto-generated by Graphite. |
benschac
commented
Feb 3, 2023
| @@ -75,72 +75,75 @@ by appending your own. A few useful ones are as follow. | |||
| ## Testnet | |||
|
|
|||
| - Currently our network requires 2 binaries | |||
| - ``` cargo build --release ``` will build both | |||
There was a problem hiding this comment.
triple backtick is for code blocks. Single is for inline code block
There was a problem hiding this comment.
benschac
force-pushed
the
fix_typos_in_readme
branch
from
cbbe751 to
df2f70e
Compare
benschac
commented
Feb 3, 2023
| - to run both you can reference /scripts/sdk-entropy-node.sh for the chain and /scripts/sdk-alice-tss.sh for the threshold client | ||
|
|
||
| ### Changing Defaults |
There was a problem hiding this comment.
Consistency, add upper case titles for headers
benschac
commented
Feb 3, 2023
README.md
Outdated
|
|
||
| ### changing defaults | ||
| - all defaults are ready to go out the box but can be changed if needed with varying degrees of difficult |
There was a problem hiding this comment.
most list markdown has been -, updated * --> - for consistency
There was a problem hiding this comment.
benschac
commented
Feb 3, 2023
| Secret phrase `where sight patient orphan general short empower hope party hurt month voice` is account: | ||
| Network ID/version: substrate | ||
| Secret seed: 0xb0b5348db82db32d10a37b578e4c6242e148f14648661dccf8b3002fafa72cdd |
There was a problem hiding this comment.
trim white space via standard prettier markdown formatting
benschac
commented
Feb 3, 2023
|
|
||
| ### Run in Docker | ||
|
|
||
| First, install [Docker](https://docs.docker.com/get-docker/) and | ||
| [Docker Compose](https://docs.docker.com/compose/install/). | ||
| First, install [Docker](https://docs.docker.com/get-docker/) and [Docker Compose](https://docs.docker.com/compose/install/). |
benschac
force-pushed
the
fix_typos_in_readme
branch
from
df2f70e to
83458df
Compare
jakehemmerle
suggested changes
Feb 3, 2023
|
In a follow-up PR on top of this PR, I can test the README and go through every single command to ensure they work. Delete/update if the command/instruction is outdated or irrelevant. |
ok-john
previously approved these changes
Feb 3, 2023
JesseAbram
previously approved these changes
Feb 3, 2023
benschac
force-pushed
the
fix_typos_in_readme
branch
from
164da76 to
c2b68ed
Compare
|
bumping @jakehemmerle to get this in your queue? This LGTM? |
jakehemmerle
previously approved these changes
Feb 16, 2023
benschac
force-pushed
the
fix_typos_in_readme
branch
from
c2b68ed to
0f6803e
Compare
JesseAbram
approved these changes
Feb 17, 2023
fjarri
pushed a commit
that referenced
this pull request
May 5, 2023
* fix typos in readme * Capitalize first word in lists
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix spelling and formatting issues in
READMEThis PR addresses the following: