Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor substrate-common to entropy-shared #272

Merged
merged 1 commit into from
Jan 31, 2023
Merged

refactor substrate-common to entropy-shared #272

merged 1 commit into from
Jan 31, 2023

Conversation

jakehemmerle
Copy link
Contributor

@jakehemmerle jakehemmerle commented Jan 30, 2023 •
edited
Loading

This PR modifies the substrate-common package:

  • refactors/renames all "substrate-common" and "substrate_common" to "entropy-shared" and "entropy_shared"
  • updates crypto/entropy-types/README.md
  • removes a few unused structs from that package

It also makes a small change to entropy-constraints Cargo.toml for properly handling std and no_std, unrelated to above

@jakehemmerle jakehemmerle force-pushed the 01-30-refactor_substrate-common_to_shared-types branch from 852f5e2 to f818f53 Compare January 30, 2023 21:48
@jakehemmerle jakehemmerle mentioned this pull request Jan 30, 2023
Merged
@jakehemmerle
Copy link
Contributor Author

Current dependencies on/for this PR:

This comment was auto-generated by Graphite.

@jakehemmerle jakehemmerle force-pushed the 01-30-refactor_substrate-common_to_shared-types branch from f818f53 to 6ceac45 Compare January 30, 2023 22:55
JesseAbram
JesseAbram previously approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@JesseAbram JesseAbram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ya looks fine.....was initially called substrate as in it needed to be shared with substrate so had to be all std to not leak wasm....but this should still be fine

@jakehemmerle jakehemmerle force-pushed the 01-30-refactor_substrate-common_to_shared-types branch from 6ceac45 to cf8e5a9 Compare January 30, 2023 23:01
@jakehemmerle jakehemmerle changed the title refactor substrate-common to shared-types refactor substrate-common to entropy-shared Jan 30, 2023
@jakehemmerle
Copy link
Contributor Author

Yeah, having shared in the name is better, so I changed it to entropy-shared since it will technically also be shared in the frontend via typegen. Naming makes sense if we add FFI stuff later too. @JesseAbram

@jakehemmerle
Copy link
Contributor Author

waiting on linting

@jakehemmerle jakehemmerle force-pushed the 01-30-refactor_substrate-common_to_shared-types branch from cf8e5a9 to f5ab2d4 Compare January 30, 2023 23:08
@jakehemmerle jakehemmerle merged commit 8ea8b3c into master Jan 31, 2023
@jakehemmerle jakehemmerle deleted the 01-30-refactor_substrate-common_to_shared-types branch January 31, 2023 17:15
@jakehemmerle jakehemmerle mentioned this pull request Feb 7, 2023
Closed
fjarri pushed a commit that referenced this pull request May 5, 2023
@jakehemmerle
refactor substrate-common to entropy-shared (#272)
b99b054 
This PR modifies the `substrate-common` package:

- refactors/renames all "substrate-common" and "substrate_common" to "entropy-shared" and "entropy_shared"
- updates crypto/entropy-types/README.md
- removes a few unused structs from that package

It also makes a small change to `entropy-constraints` Cargo.toml for properly handling std and no_std, unrelated to above
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseAbram JesseAbram JesseAbram approved these changes

@ok-john ok-john Awaiting requested review from ok-john

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakehemmerle @JesseAbram