Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] update readme in core project #265

Merged
merged 5 commits into from
Jan 30, 2023
Merged

[docs] update readme in core project #265

merged 5 commits into from
Jan 30, 2023

Conversation

benschac
Copy link
Contributor

It's not possible to run the run step without first building the core project. Moving the build step ahead of the run step is the sequential step a developer needs to take to get the project working.

README.md Outdated

```sh
cargo build --release
cargo build --release -p entropy
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mmmm this is a mis understanding this will only build the chain not the threshold server

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gotcha, I'll revert

Copy link
Contributor

@jakehemmerle jakehemmerle Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that build doesn't really do anything, since entropy (and server) got built on line 30.

change this to cargo run --release -p entropy (or just ./target/release/entropy, I still think the former is better, but if you change it, change all references of ./target/release/BIN to cargo run --release -p BIN)

README.md Outdated
@@ -58,19 +59,19 @@ node.
This command will start the single-node development chain with persistent state:

```bash
./target/release/node-template --dev
./target/release/entropy --dev
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update docs to use entropy project shell command.

@benschac benschac changed the title [docs] update readme move build step above run step [docs] update readme in core project Jan 23, 2023
@benschac benschac marked this pull request as ready for review January 23, 2023 15:55
README.md Outdated

```sh
cargo build --release
cargo build --release -p entropy
Copy link
Contributor

@jakehemmerle jakehemmerle Jan 23, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue here is that build doesn't really do anything, since entropy (and server) got built on line 30.

change this to cargo run --release -p entropy (or just ./target/release/entropy, I still think the former is better, but if you change it, change all references of ./target/release/BIN to cargo run --release -p BIN)

@benschac benschac requested a review from jakehemmerle January 25, 2023 21:41
partial update of docs
@benschac
Copy link
Contributor Author

@jakehemmerle -- seems like you want to take this one over. Happy to close this and you open a PR with your changes. They're clearly more detailed than mine.

If you don't could you update the PR description with a short description of what you did and how someone could go about testing these documentation changes?

This looks really good, ty for cleaning up these docs!

@jakehemmerle
Copy link
Contributor

@benschac thanks! just wanted to work off of what you had started so it didn't get stale.

testing them is just running the commands

@benschac
Copy link
Contributor Author

small comment: link substrate pallet docs in readme too.

@jakehemmerle
Copy link
Contributor

small comment: link substrate pallet docs in readme too.

done

@jakehemmerle jakehemmerle merged commit e8daca0 into master Jan 30, 2023
@jakehemmerle jakehemmerle deleted the updatereadme branch January 30, 2023 23:36
@benschac benschac mentioned this pull request Feb 14, 2023
fjarri pushed a commit that referenced this pull request May 5, 2023
* move build instructions to top of readme

* update build command

* replace all references of node-template with entropy

* Update README.md

partial update of docs

* Update README.md

---------

Co-authored-by: Jake Hemmerle <jakehemmerle@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants