Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add is syncing in #254

Merged
merged 11 commits into from
Dec 14, 2022
Merged

add is syncing in #254

merged 11 commits into from
Dec 14, 2022

Conversation

JesseAbram
Copy link
Member

No description provided.

@JesseAbram JesseAbram changed the title add in on chain elements add is syncing in Dec 12, 2022
@JesseAbram JesseAbram marked this pull request as ready for review December 13, 2022 20:28
@JesseAbram JesseAbram requested a review from ok-john December 13, 2022 20:28
@ok-john
Copy link
Contributor

ok-john commented Dec 14, 2022

@JesseAbram is this ready for review? tests are failing.

@JesseAbram
Copy link
Member Author

@JesseAbram is this ready for review? tests are failing.

yup just fixed should be ready now

ok-john
ok-john previously approved these changes Dec 14, 2022
Copy link
Contributor

@ok-john ok-john left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice PR, code is very clean and readable, i left you a few nits feel free to not address them

crypto/server/src/validator/api.rs Show resolved Hide resolved
crypto/server/src/validator/api.rs Show resolved Hide resolved
@JesseAbram JesseAbram requested a review from ok-john December 14, 2022 21:29
@JesseAbram JesseAbram merged commit 0a23c77 into master Dec 14, 2022
@JesseAbram JesseAbram deleted the is-syncing branch December 14, 2022 21:31
fjarri pushed a commit that referenced this pull request May 5, 2023
* add in on chain elements

* fix benchamark script

* extra substrate functions

* fmt

* fix test

* clippy ignore weights

* comments

* clippy all

* fix clippy

* clippy

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants