Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix tests #170

Merged
merged 6 commits into from
Aug 13, 2022
Merged

fix tests #170

merged 6 commits into from
Aug 13, 2022

Conversation

JesseAbram
Copy link
Member

there are still a few commented out, waiting for full implementation

@JesseAbram JesseAbram requested a review from thor314 August 12, 2022 17:54
thor314
thor314 approved these changes Aug 13, 2022
View reviewed changes
Copy link
Contributor

@thor314 thor314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, good thought on moving some of those to user

@JesseAbram
Copy link
Member Author

lgtm, good thought on moving some of those to user

thanks and I really like the api errors test mod folder layout

@JesseAbram JesseAbram merged commit 926f9d2 into master Aug 13, 2022
@JesseAbram JesseAbram deleted the test-fix branch August 13, 2022 16:26
fjarri pushed a commit that referenced this pull request May 5, 2023
@JesseAbram
fix tests (#170)
1439195 
* fix tests

* fmt

* remove duplicate code

* fmt

* nightly fmt

* fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thor314 thor314 thor314 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesseAbram @thor314