Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prune_registration extrinsic #1022

Merged
merged 7 commits into from
Aug 22, 2024
Merged

Remove prune_registration extrinsic #1022

merged 7 commits into from
Aug 22, 2024

Conversation

HCastano
Copy link
Collaborator

With the new registration flow users are registered in a single block. This means that
the prune registration extrinsic is not needed anymore since registration are never in a
pending state.

@HCastano HCastano requested review from ameba23 and JesseAbram August 21, 2024 21:21
@HCastano HCastano added the Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes) label Aug 21, 2024
ameba23
ameba23 approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@ameba23 ameba23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great ⭐

JesseAbram
JesseAbram approved these changes Aug 22, 2024
View reviewed changes
Copy link
Member

@JesseAbram JesseAbram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but probably definitely should also pull_metadata

@HCastano HCastano merged commit 260e953 into master Aug 22, 2024
8 checks passed
@HCastano HCastano deleted the hc/remove-prune-registration branch August 22, 2024 18:51
ameba23 added a commit that referenced this pull request Aug 23, 2024
@ameba23
Merge branch 'master' into peg/remove-program-test
a349405 
* master:
  Clean up registration related tests in `pallet-registry` (#1021)
  Remove `prune_registration` extrinsic (#1022)
  Add benchmark for `new_session` hook (#1016)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesseAbram JesseAbram JesseAbram approved these changes

@ameba23 ameba23 ameba23 approved these changes

Assignees
No one assigned
Labels
Bump `transaction_version` A change which affects how existing extrinsics are created (e.g parameter changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@HCastano @ameba23 @JesseAbram