Clean attestation pallet #1006
Merged
Clean attestation pallet #1006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameba23
approved these changes
Aug 15, 2024
ameba23
added a commit
that referenced
this pull request
Aug 21, 2024
* WIP attestation pallet * Improve checks for attest extrinsic * Give constant weight just to get it to compile (with warning) * Attempt to write mock runtime * Write trivial test to show mock setup works * Clean attestation pallet (#1006) * fmt * Make an attestation in the test * Lockfile * Taplo * Comments * Make quote input constructor generic, rm authorship pallet * Taplo * Add benchmarks * Taplo * Add pallet to chain runtime * Rm unused import * Improve benchmark * Generate weights * Include weights in runtime * Update metadata * Submit the attest extrinsic to test the attestation pallet * Fixes for submitting extrinsic * Update attestation endpoint in preparation for using the propagation pallet to call it * Propagation pallet propagates attestation requests * Decode input from propagation pallet * Add initial attestation requests to genesis config * Add initial attestation requests to chainspec * Pull chain metadata * Make mock attestation request at block 3 * Fix test * Tidy * Update crates/threshold-signature-server/src/attestation/api.rs Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com> * Extra check in attestation pallet benchmarks * Improve error message for unexpected attestation * Use actual weight * Add endpoint to node service * Comments and minor changed following review * Changelog --------- Co-authored-by: JesseAbram <33698952+JesseAbram@users.noreply.github.com> Co-authored-by: Hernando Castano <HCastano@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a few things I saw, feel free to close if not the vibe