fix(65): Setting variable does not work when value has dash: Updates … #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entropitor
reviewed
Mar 25, 2022
entropitor
approved these changes
Mar 25, 2022
|
Published as v5.1.0 |
|
nice |
|
First of all: thank you for your work! I stumbled upon a similar problem: Adding Can you please add this the regex? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My first PR so please be gentle 😁
I've added a new regex. It might be far from the greatest approach but seemed like a quick fix for something that's causing me and others issues.
Tested against
Also added examples https://regexr.com/6i33o