Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better compatibility #6

Merged
merged 2 commits into from
Dec 6, 2013
Merged

Better compatibility #6

merged 2 commits into from
Dec 6, 2013

Conversation

miyucy
Copy link
Contributor

@miyucy miyucy commented Jul 5, 2013

  • ActiveSupport::Base64 was removed in ActiveSupport 4.0.0. So check strictly.
  • use ActiveSupport::JSON.parse_error instead, more compat.

@PlasticLizard
Copy link

Any chance this could get merged? Thanks!

@dmitriy-kiriyenko
Copy link

Thanks, @miyucy, you saved me at least an hour. Shame on you, @entp, don't you care about your users?! Just merge it.

@braindev
Copy link

braindev commented Nov 1, 2013

+1

courtenay added a commit that referenced this pull request Dec 6, 2013
@courtenay
Merge pull request #6 from miyucy/better-compatibility
6886f61 
Better compatibility
@courtenay courtenay merged commit 6886f61 into entp:master Dec 6, 2013
@courtenay
Copy link
Collaborator

thanks ^_^

@miyucy miyucy deleted the better-compatibility branch December 8, 2013 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miyucy @PlasticLizard @dmitriy-kiriyenko @braindev @courtenay