Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send/recv buff alias problem #66

Merged
merged 1 commit into from
Oct 15, 2024
Merged

Send/recv buff alias problem #66

merged 1 commit into from
Oct 15, 2024

Conversation

haykh
Copy link
Collaborator

@haykh haykh commented Jul 29, 2024

This was less of a bug, and more of an unsafe code which was explicitly disallowed by MPICH (but not OpenMPI). Should be fixed now.

Per MPI standard

image

@haykh haykh added the bug Something isn't working label Jul 29, 2024
@haykh haykh linked an issue Jul 29, 2024 that may be closed by this pull request
@haykh
Copy link
Collaborator Author

haykh commented Jul 29, 2024

@LudwigBoess if you have time, could you test that this patch works?

@LudwigBoess
Copy link
Collaborator

Sorry for the late reply, the queue time on the machine I have access to are a nightmare.
I was able to test the MPI on CPU and can't reproduce the issue with this version. The GPU MPI run has been in the queue for 5 days, so I can't test it.

Anyway I think we can consider the bug to be fixed!

@haykh
Copy link
Collaborator Author

haykh commented Aug 7, 2024

@LudwigBoess no worries, let me know if it still persists, there is no rush about merging this.

@haykh haykh added the patch Patched version of stable release label Aug 10, 2024
Base automatically changed from 1.1.1rc to master August 17, 2024 01:35
@haykh haykh merged commit 4385c0d into master Oct 15, 2024
2 of 3 checks passed
@haykh haykh deleted the bug/mpich branch October 15, 2024 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch Patched version of stable release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MPI error with mpich
2 participants