Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error: 'InstanceFactoryChoice' object has no attribute 'object' #1989

Merged
merged 1 commit into from
Mar 20, 2023
Merged

Fix error: 'InstanceFactoryChoice' object has no attribute 'object' #1989

merged 1 commit into from
Mar 20, 2023

Conversation

hopeful0
Copy link
Contributor

@hopeful0 hopeful0 commented Mar 9, 2023

Fixed the error mentioned in issue #1988.

corranwebster
corranwebster approved these changes Mar 20, 2023
View reviewed changes
Copy link
Contributor

@corranwebster corranwebster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! This looks like it fixes the immediate problem - in the longer term I suspect that the InstanceChoiceItem ABC needs to grow a way of signalling that an update is needed to rebuild the items.

@corranwebster corranwebster merged commit 86927f5 into enthought:main Mar 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corranwebster corranwebster corranwebster approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeful0 @corranwebster