Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove 'merge_undo' from AbstractUndoItem #1515

Closed
corranwebster opened this issue Feb 8, 2021 · 0 comments · Fixed by #1999
Closed

Remove 'merge_undo' from AbstractUndoItem #1515

corranwebster opened this issue Feb 8, 2021 · 0 comments · Fixed by #1999
Labels
component: core Issues related to the core functionality, ui composition and life cycle. type: cleanup Issues related to clean up _excluding_ refactoring
Milestone
Release 8.0

Comments

@corranwebster
Copy link
Contributor

This method is deprecated in favour of merge in #1510 and use raises a deprecation warning. It should be removed in TraitsUI 8.0, but not before (although the chance of breaking other's code is low).
@corranwebster corranwebster added component: core Issues related to the core functionality, ui composition and life cycle. type: cleanup Issues related to clean up _excluding_ refactoring labels Feb 8, 2021
@corranwebster corranwebster added this to the Release 8.0 milestone Feb 8, 2021
@rahulporuri rahulporuri mentioned this issue Feb 9, 2021
Merged
corranwebster added a commit that referenced this issue Mar 21, 2023
@corranwebster
Remove merge_undo from undo code.
d85e632 
Fixes #1515

This completes the transition of TraitsUI undo/redo to share the same basis
as the Pyface/Apptools undo/redo
@corranwebster corranwebster mentioned this issue Mar 21, 2023
Merged
1 task
corranwebster added a commit that referenced this issue Mar 21, 2023
@corranwebster
Remove merge_undo from undo code. (#1999)
0b97654 
Fixes #1515.  Also removes a no-longer used `history` trait.

This completes the transition of TraitsUI undo/redo to share the same basis as the Pyface/Apptools undo/redo.

There is still an issue in #1060 that is unresolved which is about refactoring TraitsUI to be more command-stack based, rather than building the command stack reactively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: core Issues related to the core functionality, ui composition and life cycle. type: cleanup Issues related to clean up _excluding_ refactoring
Projects
None yet
Milestone
Release 8.0
Development

Successfully merging a pull request may close this issue.

Remove merge_undo from undo code. enthought/traitsui
1 participant
@corranwebster