Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General performance issues #16

Open
Porkepix opened this issue Jan 9, 2024 · 10 comments
Open

General performance issues #16

Porkepix opened this issue Jan 9, 2024 · 10 comments
Labels
performance All things related to performance issues

Comments

@Porkepix
Copy link

Porkepix commented Jan 9, 2024

Application is still quite recent so those things can happen, but it does have quite some performance issues.
First on the first launch for the global indexing of all of your songs, but even after that for example for the dynamic theming, which is causing some performance problems, especially when switching to a song with no cover.

Dunno what I can add there to help on that topic.

Device details:
Xperia XZ running Android Oreo (8.0) on stock ROM.

EDIT: To be more precise, first song indexing took at least 10 minutes I think, went quite slowly, and only offering 6 things to read during that time. You can't even set the folders first.

@enteraname74
Copy link
Owner

I know that the first launch can be quite long, do you have a lot of songs on your device?
For the dynamic theme, I will try to better optimize it.

It could be a good thing to select folders to use before fetching songs for the first time. I will implement that when I can.

@enteraname74 enteraname74 added the performance All things related to performance issues label Jan 9, 2024
@Porkepix
Copy link
Author

Porkepix commented Jan 9, 2024

Currently, 844 songs, all of them on the SD card.
Thing is, this could be done concurrently in another thread while letting the user use the application. Especially here the 6 cards you can scroll were quite laggy.
And clearly I tried quite a couple of players on Android and the time it took for indexing is a lot more than the average time I'd say.

@enteraname74
Copy link
Owner

Okay, I see.
The fetching is done in another thread, but it is clear that something should be done to improve the performance in that part. I work on it when I can.

@gargamel17
Copy link

More than 20000 songs on sdcard, first launch never completes

@enteraname74
Copy link
Owner

I'm currently working on ways to improve the logic of the data fetching. It's one of the things where the app needs a rework. I will let you know when a faster system is made.

@Porkepix
Copy link
Author

Porkepix commented Oct 7, 2024

Same here, even with less than a thousand songs, indexing them takes a very long time when other players with the same music collection do it a whole lot faster.

The transition between songs isn't yet perfectly smooth, but seems to be a lot smoother than what it used to be.

@enteraname74
Copy link
Owner

enteraname74 commented Oct 23, 2024

App performance is heavily improved in the latest version of the app (v0.9.0). It includes primarily song fetching and cover management.
For example, on the v0.8.1, 890 songs took 3 minutes and 30 seconds to load. Now it takes 2 seconds in the v0.9.0.
I tested it on several Android versions and it should work properly.

However, I don't know if it can handle well more than 20000 songs! Let me know if it works correctly in your case @gargamel17

@gargamel17
Copy link

gargamel17 commented Oct 25, 2024 via email

@Porkepix
Copy link
Author

App performance is heavily improved in the latest version of the app (v0.9.0). It includes primarily song fetching and cover management. For example, on the v0.8.1, 890 songs took 3 minutes and 30 seconds to load. Now it takes 2 seconds in the v0.9.0. I tested it on several Android versions and it should work properly.

However, I don't know if it can handle well more than 20000 songs! Let me know if it works correctly in your case @gargamel17

I can indeed confirm initial music indexing is a lot faster. Not instant, nor "backgrounded". It can maybe go faster, but speed doesn't looks shocking for now, an improvement could be to let the user use the application while indexing is ongoing.

On the other hand, everything related to GUI loading, transitions and globally every GUI drawing/rendering still have very bad performances, it's not fluid, nor synchronized: when we move onto the next song for example, things change little by little like you could have cover changing and then backgrounds colors between 0.5 and 2/3s later.

@enteraname74
Copy link
Owner

I don't have such bad performances, so it will be difficult to improve the system, but I always try to improve what's already existing, so I will see if I can better optimize it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance All things related to performance issues
Projects
None yet
Development

No branches or pull requests

3 participants