This repository has been archived by the owner on May 14, 2024. It is now read-only.
Fix yarn workspace photos add foo
#1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was likely happening because the package versions in the top level package.json and the eslint-config package.json were different. I've synced them for now. > On a longer time frame, the idea is not have such conflicting cases, and remove mostly all the top level package.json dependencies and for the rest rely on them solely being in the top level package.json and not duplicated in two places.
These were introduced since we updated the eslint-package version.
Deploying with
|
| Latest commit: |
dd6d599
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://23d263c5.bada-frame.pages.dev |
| Branch Preview URL: | https://fix-yarn-add.bada-frame.pages.dev |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was likely happening because the package versions in the top level package.json and the eslint-config package.json were different. I've synced them for now.
Since the eslint plugin version was updated, there were some new warnings that I had to temporarily suppress.
Tested by
Before this change, the following (arbitrary package) install was failing
It works afterwords.