Dispatch of `to_text`, `is_a` & co. on intersection types #12192

JaroslavTulach · 2025-01-30T11:50:06Z

Pull Request Description

Fixes #11827 by keeping EnsoMultiValue as self when dispatching methods like Any.to_text or Any.is_a. The major changes shall be visible in tests:

no special handling of to_text for EnsoMultiValue
also Any.is_a is dispatched differently
before the dispatch the firstDispatch type is updated
IntegerNode had to be updated - the whole package to be ready for EnsoMultiValue being self
Tested as IntegerTest
Tested as FloatTest
case of support updated to handle EnsoMultiValue
search for execute method extended to superclasses

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

All code follows the
Scala,
Java,
Unit tests have been written where possible.

…MultiValue.values

…s via StructsLibrary

JaroslavTulach · 2025-01-30T14:48:48Z

engine/runtime/src/main/java/org/enso/interpreter/node/callable/InvokeMethodNode.java

@@ -302,7 +302,7 @@ Object doMultiValue(
    if (fnAndType != null) {
      var ctx = EnsoContext.get(this);
      if (ctx.getBuiltins().any() != fnAndType.getRight()) {
-        var unwrapSelf = castTo.findTypeOrNull(fnAndType.getRight(), self, false, false);
+        var unwrapSelf = castTo.findTypeOrNull(fnAndType.getRight(), self, true, false);


Reorders the intersection types to make sure the value of the type we dispatch the method to is at EnsoMultiValue.firstDispatch.

test/Base_Tests/src/Semantic/Multi_Value_As_Type_Refinement_Spec.enso

JaroslavTulach · 2025-01-31T03:33:04Z

Now, when dispatch of an instance method allows self to be an EnsoMultiValue we have problems with builtins! They don't want multi value, but they need the right type to be extracted from the multivalue:

Use BuiltinRootNode.ArgNode to extract argument for a builtin method #12201

To do so we have to change the "builtin prelude code" - e.g. the way we prepare the values before invoking the @BuiltinMethod. The work is blocking progress on this PR, but it should rather be implemented as a separate PR #12201 to make sure compatibility is fully guaranteed.

enso-bot · 2025-02-05T03:36:23Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-02-04):

Progress: .

bugfixing ArgNode: Use BuiltinRootNode.ArgNode to extract argument for a builtin method #12201
benchmarking: https://github.com/enso-org/enso/actions/runs/13142004968
IfThenElse IR in Java: Recognize if-like Tree.MultiSegmentApp as IfThenElse IR #11365 (comment)
cache Rust build tool: https://github.com/orgs/enso-org/discussions/12189#discussioncomment-12050422
review CI changes: New gate for stdlib API check #12223 (review)
"anchor location" PoC: Base_Tests slowed down by 4min(!) due to too frequent get_source_location calls #12215 (comment)
planning meeting It should be finished by 2025-02-10.

GitHub
Benchmark Engine · enso-org/enso@3579139
Enso Analytics is a self-service data prep and analysis platform designed for data teams. - Benchmark Engine · 3579139

GitHub
Bazel: goals, roadmap, expectations · enso-org · Discussion #12189
We wanted to provide additional context for the work of moving our build system to Bazel, answer common questions, provide some expectations, and explain our long-term goals. So here it is. Goals W...

enso-bot · 2025-02-06T03:34:44Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-02-05):

Progress: .

benchmarking & speed up: f211c19
State and Contexts are not preserved through the Polyglot boundary #7117: removing State from method signatures: Removing State from method signatures #12233
Investigating RuntimeErrosTest failure: https://github.com/enso-org/enso/pull/12233/files#r1943397059
dispatch discussions: Method dispatch ordering: should we traverse all multi values before checking the parent types? #12185 (comment)
history of native launcher: CI should run Standard Library Tests in both JVM and Native modes #12123 (comment)
many meetings It should be finished by 2025-02-10.

GitHub
Removing State from method signatures by JaroslavTulach · Pull Request #12233 · enso-org/enso
Pull Request Description Fixes #7117 by removing State from method signatures and moving it into EnsoContext thread context local variable. Checklist Please ensure that the following checklist has ...

enso-bot · 2025-02-07T05:26:53Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-02-06):

Progress: .

review Radek's oversaturated argument PR: Improve error reporting of named argument mismatch #12238 (review)
Fixing State: Removing State from method signatures #12233 (comment)
Analyzing benchmarks: Removing State from method signatures #12233 (comment)
speculate on single state: 4ef8f4d
testing Tableau: Add Standard.Tableau to native-image #12204 (comment)
updating .bgv PR: bad28dd
EqualsNode fighting: https://discord.com/channels/@me/948519891961544714/1337096178658967593 It should be finished by 2025-02-10.

Discord
Discord - Group Chat That’s All Fun & Games
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

enso-bot · 2025-02-07T16:28:50Z

Jaroslav Tulach reports a new STANDUP for today (2025-02-07):

Progress: .

debugging double != long
EnsoHashMap fix: Use BuiltinRootNode.ArgNode to extract argument for a builtin method #12201 (comment)
reordered warnings: 560e6b7
review: Expression update contains full multi-value info #12195 (review)
review of No_Such_Argument: Improve error reporting of named argument mismatch #12238 (comment)
trying to install pyarrow: https://graalvm.slack.com/archives/CNA7PDH2N/p1738927957031579?thread_ts=1738926961.249839&cid=CNA7PDH2N
propagating progress to the API
trying to launch the IDE (no luck): https://discord.com/channels/@me/948519891961544714/1337455378333696115
meetings It should be finished by 2025-02-10.

Discord
Discord - Group Chat That’s All Fun & Games
Discord is great for playing games and chilling with friends, or even building a worldwide community. Customize your own space to talk, play, and hang out.

#12201) - as #12192 (comment) states: - there is a need to extract values from `EnsoMultiValue` in the _"builtin method prelude code"_ - to enable _specializations based on type of arguments_, we need to wrap such _prelude_ by a `Node` - hence introducing `ArgNode` & co. - it kinda replaces the _"static code emitted"_ by annotation processor - with Truffle `@Specialization`s done inside of `ArgNode` - making this all more Truffle-like

enso-bot · 2025-02-11T03:32:08Z

Jaroslav Tulach reports a new STANDUP for yesterday (2025-02-10):

Progress: .

PR merged: Use BuiltinRootNode.ArgNode to extract argument for a builtin method #12201
updated to_text with develop: f6e5ef9
case bool of: b7e55e7
rewriting IntegerNodes to Binary and Unary
(standup) meetings It should be finished by 2025-02-10.

JaroslavTulach · 2025-02-11T16:25:10Z

...ne/runtime-integration-tests/src/test/java/org/enso/interpreter/test/EnsoMultiValueTest.java

+        (tripple) -> {
+          var texts = tripple.as(new TypeLiteral<List<String>>() {});
+          assertEquals(3, texts.size());
+          assertStartsWith("(A_Ctor", texts.get(0));


There is no special handling of EnsoMultiValue.to_text anymore. v.to_text dispatches the same as (v:A).to_text.

JaroslavTulach · 2025-02-11T16:27:12Z

test/Base_Tests/src/Semantic/Multi_Value_As_Type_Refinement_Spec.enso

            ab = make_a_and_b

            # Checked variant can hide the B part
            ab.a_id . is_a A . should_be_true
-            ab.a_id . is_a B . should_be_false
+            ab.a_id . is_a B . should_be_true # B is a hidden type


Any.is_a uses EnsoMultiValue as self and thus the B remains hidden type

JaroslavTulach · 2025-02-11T16:29:23Z

...s/src/test/java/org/enso/interpreter/node/expression/builtin/number/integer/IntegerTest.java

+          var textType = leak.getBuiltins().text();
+          var both = new Type[] {intType, textType};
+          var twentyTwoHello = nn.newValue(both, 2, 0, new Object[] {22L, "Hello"});
+          assertEquals(23L, addNode.execute(twentyTwoHello, 1L));


Verified IntegerNode.Binary accepts EnsoMultiValue

JaroslavTulach · 2025-02-11T16:30:09Z

...sts/src/test/java/org/enso/interpreter/node/expression/builtin/number/decimal/FloatTest.java

+    ContextUtils.executeInContext(
+        ctx,
+        () -> {
+          assertEquals(23.1, addNode.execute(22.1, 1L), 0.01);


AddNode for Float handles both long as well as double as second argument.

JaroslavTulach · 2025-02-11T16:31:05Z

engine/runtime-integration-tests/src/test/java/org/enso/interpreter/test/CaseOfTest.java

+        new Type[] {leak.getBuiltins().bool().getType(), leak.getBuiltins().number().getInteger()};
+    var t = n.newValue(bAndT, 2, 0, new Object[] {true, 300});
+    var f = n.newValue(bAndT, 2, 0, new Object[] {false, 200});
+    doCaseOfBoolean(t, f);


case bool of needs to handle both Boolean as well as EnsoMultiValue.

JaroslavTulach · 2025-02-11T16:32:11Z

lib/scala/interpreter-dsl/src/main/java/org/enso/interpreter/dsl/impl/MethodProcessor.java

-    MethodDefinition def = new MethodDefinition(pkgName, element, executeMethod, needsFrame);
-    if (!def.validate(processingEnv)) {
-      return;
+  private Element findExecuteMethod(TypeElement e) {


Searches for execute method also in super classes, so it finds one provided by Integer.BinaryNode.

radeusgd · 2025-02-12T16:17:41Z

test/Base_Tests/src/Semantic/Multi_Value_As_Type_Refinement_Spec.enso

@@ -165,7 +165,7 @@ add_specs suite_builder =
            (c:A&B&C).b_method . should_equal "B method"
            (c:A&B&C).c_method . should_equal "C method"

-        group_builder.specify "default to_text should delegate to one of values" pending="TODO: https://github.com/enso-org/enso/issues/11827" <|
+        group_builder.specify "default to_text should delegate to one of values" pending="To text doesn't dispatch properly #11827" <|


If this PR fixes #11827 then why is this test still marked as pending?

Does that mean that #11827 is not resolved and shouldn't be closed? Or should we unmark this test and start running it?

JaroslavTulach added 3 commits January 30, 2025 10:39

Keep order of extra types when moveToFirst to match the order of Enso…

86ce764

…MultiValue.values

Keep EnsoMultiValue.self while dispatching non-Any methods

6758f92

Explain why the tests are pending

9c3973e

JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Jan 30, 2025

JaroslavTulach self-assigned this Jan 30, 2025

JaroslavTulach requested review from jdunkerley, radeusgd, GregoryTravis, AdRiley, marthasharkey, 4e6, hubertp and Akirathan as code owners January 30, 2025 11:50

JaroslavTulach marked this pull request as draft January 30, 2025 11:50

4e6 approved these changes Jan 30, 2025

View reviewed changes

JaroslavTulach changed the title ~~Polish to_text on _intersection types_~~ Polish to_text on intersection types Jan 30, 2025

castTo self type while reorderOnly in order to access the right field…

3196767

…s via StructsLibrary

JaroslavTulach force-pushed the wip/jtulach/MultiValueToText11827 branch from 91597b5 to 3196767 Compare January 30, 2025 14:41

JaroslavTulach commented Jan 30, 2025

View reviewed changes

test/Base_Tests/src/Semantic/Multi_Value_As_Type_Refinement_Spec.enso Show resolved Hide resolved

raiseAssertionPanic on unexpected builtin argument

af66692

JaroslavTulach mentioned this pull request Jan 30, 2025

Use BuiltinRootNode.ArgNode to extract argument for a builtin method #12201

Merged

4 tasks

enso-bot bot mentioned this pull request Jan 31, 2025

Calling a method that returns 'itself' on a multi-value should not lose multi-value structure? #12143

Closed

Merging with BuildRootNode.ArgNode from develop

f6e5ef9

JaroslavTulach added 6 commits February 10, 2025 05:23

case boolean of can be performed on non-primitive booleans

b7e55e7

There are no Theories in this test

9431e0f

Moving processors outside of exported package

28f0124

No need for Google dependency anymore

ca3f92a

More tests on Integer type

8506157

Possible quick fix for integer.AddNode

75be351

Introducing IntegerNode.Unary and IntegerNode.Binary nodes

0e3af2e

JaroslavTulach added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Feb 11, 2025

JaroslavTulach added 2 commits February 11, 2025 06:17

Adding FloatTest

5a497f6

Second argument of IntegerNode.Binary can be double

62de581

unfurl-links bot mentioned this pull request Feb 11, 2025

Enable ydoc-server tests #12252

Merged

5 tasks

Support EnsoMultiValue as self in GetFieldWithMatchNode

3ec9b59

JaroslavTulach commented Feb 11, 2025

View reviewed changes

JaroslavTulach marked this pull request as ready for review February 11, 2025 16:33

JaroslavTulach requested a review from 4e6 February 11, 2025 16:33

JaroslavTulach changed the title ~~Polish to_text on intersection types~~ Classical dispatch of to_text, is_a & co. on intersection types Feb 11, 2025

JaroslavTulach changed the title ~~Classical dispatch of to_text, is_a & co. on intersection types~~ Dispatch of to_text, is_a & co. on intersection types Feb 12, 2025

enso-bot bot mentioned this pull request Feb 12, 2025

Let EnsoMultiValue.to_text delegate to first type to_text #11827

Closed

Akirathan approved these changes Feb 12, 2025

View reviewed changes

GregoryTravis approved these changes Feb 12, 2025

View reviewed changes

JaroslavTulach merged commit 595e0a8 into develop Feb 12, 2025
53 checks passed

JaroslavTulach deleted the wip/jtulach/MultiValueToText11827 branch February 12, 2025 14:35

radeusgd reviewed Feb 12, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Dispatch of `to_text`, `is_a` & co. on intersection types #12192

Dispatch of `to_text`, `is_a` & co. on intersection types #12192

JaroslavTulach commented Jan 30, 2025 •

edited

Loading

JaroslavTulach Jan 30, 2025

JaroslavTulach commented Jan 31, 2025

enso-bot bot commented Feb 5, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 6, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 7, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 7, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 11, 2025

JaroslavTulach Feb 11, 2025

JaroslavTulach Feb 11, 2025

JaroslavTulach Feb 11, 2025

JaroslavTulach Feb 11, 2025

JaroslavTulach Feb 11, 2025

JaroslavTulach Feb 11, 2025

radeusgd Feb 12, 2025

Dispatch of to_text, is_a & co. on intersection types #12192

Dispatch of to_text, is_a & co. on intersection types #12192

Conversation

JaroslavTulach commented Jan 30, 2025 • edited Loading

Pull Request Description

Checklist

Choose a reason for hiding this comment

JaroslavTulach commented Jan 31, 2025

enso-bot bot commented Feb 5, 2025 • edited by unfurl-links bot Loading

enso-bot bot commented Feb 6, 2025 • edited by unfurl-links bot Loading

enso-bot bot commented Feb 7, 2025 • edited by unfurl-links bot Loading

enso-bot bot commented Feb 7, 2025 • edited by unfurl-links bot Loading

enso-bot bot commented Feb 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Dispatch of `to_text`, `is_a` & co. on intersection types #12192

Dispatch of `to_text`, `is_a` & co. on intersection types #12192

JaroslavTulach commented Jan 30, 2025 •

edited

Loading

enso-bot bot commented Feb 5, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 6, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 7, 2025 •

edited by unfurl-links bot

Loading

enso-bot bot commented Feb 7, 2025 •

edited by unfurl-links bot

Loading