CodeEditor improvements #11852
Merged
CodeEditor improvements #11852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Auto-indent: - New line matches indentation of previous line - Backspace now deletes 4 spaces of indentation - New `Ast`-based implementation of `ensoSyntax` extension - Stylesheet-defined syntax highlighting (fixes #11475) - Vue component implementation of code editor tooltips - Removes 2nd-to-last usage of `RawAst` (#10753) - Switch to CM-compatible SourceRange so that we can use the same text algorithms for module sources and CM editor contents - Update CodeMirror dependencies
kazcw
added
the
CI: No changelog needed
kazcw
requested review from
Frizi,
farmaazon,
vitvakatu,
AdRiley,
PabloBuchu,
indiv0,
somebody1234 and
MrFlashAccount
as code owners
🧪 Storybook is successfully deployed!📊 Dashboard:
|
farmaazon
approved these changes
Dec 16, 2024
Comment on lines
12
to
20
| /** TODO: Add docs */ | ||
| export function sourceRangeKey({ from, to }: SourceRange): SourceRangeKey { | ||
| return `${from.toString(16)}:${to.toString(16)}` as SourceRangeKey | ||
| } | ||
| /** TODO: Add docs */ | ||
| export function sourceRangeFromKey(key: SourceRangeKey): SourceRange { | ||
| const [from, to] = key.split(':').map(x => parseInt(x, 16)) as [number, number] | ||
| return { from, to } | ||
| } |
There was a problem hiding this comment.
As these functions are now outside their usage context, let's add short docs there.
jdunkerley
pushed a commit
that referenced
this pull request
Dec 17, 2024
(cherry picked from commit aebfacd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeEditor improvements in preparation for rendering uncommitted edits (#11798)
Ast-based implementation ofensoSyntaxextensionprivateisn't recognized as a keyword by the IDE's editor #11475)RawAst(Port users ofRawAsttoAst✨🚀 #10753)SourceRangetype so that we can use the same text algorithms for module sources and CM editor contentsPull Request Description
Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.