Ydoc library #11615
Merged
Ydoc library #11615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4e6
added
the
CI: No changelog needed
4e6
requested review from
JaroslavTulach,
hubertp and
Akirathan
as code owners
There was a problem hiding this comment.
I would really like to see #11477 addressed in this PR. There is one essential and one verification step:
- modify ContextInsightSetup to enable ydoc polyfills that are provided by the newly defined
ydoc(as named currently) library - verify (maybe just manually) that the generated
ydoc.cjscan be specified by-Denso.dev.insightproperty, loads correctly and runs the wayYdocis supposed to run
Can we move forward with #11477, please?
build.sbt
Outdated
| @@ -1885,13 +1886,49 @@ lazy val searcher = project | |||
| .dependsOn(testkit % Test) | |||
| .dependsOn(`polyglot-api`) | |||
|
|
|||
| lazy val ydoc = project | |||
| .in(file("lib/java/ydoc")) | |||
There was a problem hiding this comment.
Why it is called ydoc? The library itself has nothing to do with ydoc, it is websocket and other node.js APIs polyfill necessary to execute ydoc on JVM.
Maybe ydoc-polyfill? Or polyfills4ydoc? Or graal-js-polyfills?
| import org.enso.ydoc.jsonrpc.model.result.FileListResult; | ||
| import org.enso.ydoc.jsonrpc.model.result.InitProtocolConnectionResult; | ||
| import org.enso.ydoc.jsonrpc.model.result.TextOpenFileResult; | ||
| import org.enso.ydoc.server.jsonrpc.JsonRpcRequest; |
There was a problem hiding this comment.
Wow: So many jsonrpc classes just for testing purposes!
I wasn't aware we have so many classes related to mock communication with language server. Do they mock the communication? What do they actually test?
There was a problem hiding this comment.
They need to emulate initialization message exchange with the language server
JaroslavTulach
approved these changes
Nov 25, 2024
4e6
requested review from
radeusgd,
jdunkerley,
GregoryTravis,
AdRiley and
marthasharkey
as code owners
GregoryTravis
approved these changes
Nov 25, 2024
hubertp
added a commit
that referenced
this pull request
Nov 26, 2024
`ydoc-server` compilation requires generation of `ydoc.cjs` resource that can take time and slow down the libraries development (building the enso distribution). This PR splits Ydoc into a library and the server part to avoid JS resources generation during the compilation of the language server. Changelog: - refactor: Ydoc into ~~`ydoc`~~ `ydoc-polyglot` library and `ydoc-server` server parts - update: language server to depend on the ~~`ydoc`~~ `ydoc-polyglot` library
mergify bot
pushed a commit
that referenced
this pull request
Nov 27, 2024
Fixes the `sbt std-benchmarks/run` runtime module path. Before #11615 the `std-benchmarks` had `logging-service-logback` as a [transitive dependency of the `ydoc-server`](https://github.com/enso-org/enso/pull/11615/files#diff-5634c415cd8c8504fdb973a3ed092300b43c4b8fc1e184f7249eb29a55511f91L4052). Now is should be provided explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
ydoc-servercompilation requires generation ofydoc.cjsresource that can take time and slow down the libraries development (building the enso distribution). This PR splits Ydoc into a library and the server part to avoid JS resources generation during the compilation of the language server.Changelog:
ydocydoc-polyglotlibrary andydoc-serverserver partsydocydoc-polyglotlibraryImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.