Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Graph.nextId() private #11486

Merged
merged 4 commits into from
Nov 5, 2024
Merged

Make Graph.nextId() private #11486

merged 4 commits into from
Nov 5, 2024

Conversation

JaroslavTulach
Copy link
Member

@JaroslavTulach JaroslavTulach commented Nov 4, 2024 •
edited
Loading

Pull Request Description

Simplification of relation between Use, Def and Graph. Graph is now factory for Use and Def. There is no need for nextId() to be visible to users of the "graph API".

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • All code follows the
    Scala,
    Java,
  • Unit tests continue to pass

@JaroslavTulach JaroslavTulach added the CI: No changelog needed Do not require a changelog entry for this PR. label Nov 4, 2024
@JaroslavTulach JaroslavTulach self-assigned this Nov 4, 2024
@JaroslavTulach
Copy link
Member Author

Discovered while working on #11365

Akirathan
Akirathan approved these changes Nov 4, 2024
View reviewed changes
Copy link
Member

@Akirathan Akirathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@JaroslavTulach JaroslavTulach added CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. labels Nov 4, 2024
@enso-bot enso-bot bot mentioned this pull request Nov 5, 2024
Merged
2 tasks
@JaroslavTulach JaroslavTulach merged commit 988316f into develop Nov 5, 2024
40 of 41 checks passed
@JaroslavTulach JaroslavTulach deleted the wip/jtulach/PrivateNextId11365 branch November 5, 2024 04:21
@JaroslavTulach JaroslavTulach mentioned this pull request Nov 5, 2024
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Akirathan Akirathan Akirathan approved these changes

@4e6 4e6 Awaiting requested review from 4e6 4e6 is a code owner

@hubertp hubertp Awaiting requested review from hubertp hubertp is a code owner

Assignees

@JaroslavTulach JaroslavTulach

Labels
CI: Clean build required CI runners will be cleaned before and after this PR is built. CI: Keep up to date Automatically update this PR to the latest develop. CI: No changelog needed Do not require a changelog entry for this PR.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JaroslavTulach @Akirathan