Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reload insight script on file change #11415

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Reload insight script on file change #11415

merged 1 commit into from
Oct 28, 2024

Conversation

4e6
Copy link
Contributor

@4e6 4e6 commented Oct 25, 2024

Pull Request Description

Changelog:

  • update: reload insight script when the file was edited

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@4e6 4e6 added the CI: No changelog needed Do not require a changelog entry for this PR. label Oct 25, 2024
@4e6 4e6 self-assigned this Oct 25, 2024
Copy link
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I hope it does work and improves the UX.

Shouldn't the description of this PR or some other documentation changes describe how one is supposed to develop with enso.dev.insight? E.g. that automatic reload is now on?

@4e6
Copy link
Contributor Author

4e6 commented Oct 28, 2024

Yes, the reloading is always enabled. For now, it should be ok because the property should be used only for development purposes

@4e6 4e6 added the CI: Ready to merge This PR is eligible for automatic merge label Oct 28, 2024
@mergify mergify bot merged commit d16fd63 into develop Oct 28, 2024
42 of 43 checks passed
@mergify mergify bot deleted the wip/db/insight-reload branch October 28, 2024 09:17
@JaroslavTulach
Copy link
Member

JaroslavTulach commented Nov 4, 2024

I am experimenting with Detect Assign Statements "useful" script. E.g.

  • store the script into in.js
  • launch project-manager as ENSO_JVM_OPTS=-Denso.dev.insight=pwd/in.js sbt --java-home ~/bin/graalvm/ runProjectManagerDistribution
  • launching IDE in another terminal as corepack pnpm run dev:gui
  • opening in.js in an editor

Whenever I alter the script, the changes are picked immediately up as soon as any Enso code is re-executed. Great work!

The next step is to expose Y.doc server structures (e.g. especially the node.js emulation) to this Enso Insight script.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. CI: Ready to merge This PR is eligible for automatic merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants