Verify ./runner executable on all supported OSes #10329
Conversation
JaroslavTulach
added
the
CI: No changelog needed
|
I guess all the Base_Tests continue to run without any error. |
JaroslavTulach
changed the title
| @@ -1800,458 +1800,6 @@ | |||
| "name":"org.enso.base_test_helpers.RangeStream", | |||
| "methods":[{"name":"<init>","parameterTypes":["int", "int"] }] | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
Additional NI related fix:
Persistance discovers all the available implementations via META-INF/services/ lookup. That would require reflective access to constructor. However such a discovery is now only performed in static initializer of the class - e.g. during build time of Native image. Hence no reflective operations with Persistance subclasses shall be performed during native executable execution. Removing persistance related debris from the reflection configuration file.
JaroslavTulach
requested review from
jdunkerley,
AdRiley and
Frizi
as code owners
Both issues shall be solved by 71b20a7 |
|
The windows job has succeeded in 14min. The Mac OS X job succeeded as well but it took one hour. Obviously Linux job was successful in 23min. We could make these numbers lower by removing the NI+Espresso build - that one is highly experimental and needs only to be executed on a single platform. Update after 1b0d22e that removed Espresso+NI check on Mac and Windows we get :
|
JaroslavTulach
force-pushed
the
wip/jtulach/PersistWithReflection10126
branch
from
f6d32ce to
1b0d22e
Compare
| "--add-modules", | ||
| s"$NI_MODULES,$JDK_MODULES,$DEBUG_MODULES,$PYTHON_MODULES" | ||
| ) | ||
| val exitCode = scala.sys.process.Process(jlink.toString(), jlinkArgs).! |
There was a problem hiding this comment.
@jdunkerley reports https://github.com/enso-org/enso/actions/runs/9184711886/job/26530345747 failure on Mac Arm. It looks like a space in path issue and it should be fixed by this change.
| @@ -433,9 +433,9 @@ impl Processor { | |||
| arg::backend::Command::CiCheck {} => { | |||
| let config = enso_build::engine::BuildConfigurationFlags { | |||
| build_benchmarks: true, | |||
| // Windows is not yet supported for the native runner. | |||
| build_native_runner: enso_build::ci::big_memory_machine() | |||
There was a problem hiding this comment.
I am wondering why we build_native_runner on Mac Arm? Probably the Mac Arm classifies as big_memory_machine...
Pull Request Description
Follow up to #10126. If we want to use the
./runnerexecutable as the default launcher, we need to make sure it builds and runs on all operating systems we support.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR: