TextEdit with custom IdMap #10283
TextEdit with custom IdMap #10283
Conversation
4e6
added
the
CI: No changelog needed
|
Currently, the IdMap in the file is replaced and not updated. In the future we can add a parameter that will only include the updated values |
| this.idMap = Collections.emptyMap(); | ||
| } | ||
|
|
||
| public TreeToIr(Map<Location, UUID> idMap) { |
There was a problem hiding this comment.
- remove
publicand makeprivate - create a factory method
- remove
MODULEconstant and use the factory method
| * | ||
| * @param values the list of span-uuid pairs | ||
| */ | ||
| case class IdMap(values: Vector[(Span, UUID)]) |
There was a problem hiding this comment.
Why do we have Pair of Pair and UUID when the protocol talkes about tripple?
| @@ -86,6 +88,8 @@ void initializeBuiltinsIr( | |||
|
|
|||
| CharSequence getCharacters(Module module) throws IOException; | |||
|
|
|||
| IdMap getIdMap(Module module); | |||
There was a problem hiding this comment.
Why do you need this method, when there also is:
public abstract IdMap getIdMap();on the Module itself? Looks like unnecessary duplication.
| import org.enso.compiler.core.ir.Location; | ||
|
|
||
| /** A mapping between the code {@link Location}s and their identifiers. */ | ||
| public record IdMap(Map<Location, UUID> values) { |
There was a problem hiding this comment.
Why do we need a special IdMap record instead of directly using the Map?
| import java.util.UUID; | ||
| import org.enso.compiler.core.ir.Location; | ||
|
|
||
| /** A mapping between the code {@link Location}s and their identifiers. */ |
There was a problem hiding this comment.
Why don't se use @ExternalId annotation like elsewhere, @hubertp?
| * @tparam A the source type | ||
| */ | ||
| case class Changeset[A]( | ||
| source: A, | ||
| ir: IR, | ||
| simpleUpdate: Option[SimpleUpdate], | ||
| invalidated: Set[UUID @ExternalID] | ||
| invalidated: Set[UUID @ExternalID], |
There was a problem hiding this comment.
Here we use @ExternalID - why it is not used everywhere in the new code, @hubertp?
Pull Request Description
close #10182
Changelog:
text/applyEditrequestTreeToIRparsing stepImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.