Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdlibs benchmark regression #9470

Closed
Akirathan opened this issue Mar 19, 2024 · 1 comment · Fixed by #9646
Closed

stdlibs benchmark regression #9470

Akirathan opened this issue Mar 19, 2024 · 1 comment · Fixed by #9646
Assignees
Labels
--low-performance -compiler -libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint

Comments

@Akirathan Akirathan added p-high Should be completed in the next sprint --low-performance labels Mar 19, 2024
@Akirathan Akirathan added -compiler -libs Libraries: New libraries to be implemented labels Mar 19, 2024
@JaroslavTulach JaroslavTulach moved this from ❓New to 📤 Backlog in Issues Board Mar 19, 2024
@Akirathan
Copy link
Member Author

Looking into the Table_Sorting.table_order_by_objects benchmark:

  • It seems that the warmup is not sufficient, increased the warmup to 7 iterations per 7 seconds and measurement to 7 iterations per 7 seconds.
    • It seems that the benchmark is now unstable - in some executions I am seeing similar results to the old (good) revision, in some executions, I am seeing 2x slowdown.
    • Let's increase the warmup and measurement phases for now and analyze further in the future, if necessary.

@Akirathan Akirathan linked a pull request Apr 8, 2024 that will close this issue
5 tasks
Akirathan added a commit that referenced this issue Apr 8, 2024
* Do not disable BackgroundCompilation in benchmarks

* Increase warmup for Table sorting benchmarks.

#9470
@github-project-automation github-project-automation bot moved this from 📤 Backlog to 🟢 Accepted in Issues Board Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
--low-performance -compiler -libs Libraries: New libraries to be implemented p-high Should be completed in the next sprint
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant