Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow per-project JVM mode #12529

Closed
hubertp opened this issue Mar 18, 2025 · 3 comments · Fixed by #12550
Closed

Allow per-project JVM mode #12529

hubertp opened this issue Mar 18, 2025 · 3 comments · Fixed by #12550
Assignees
@hubertp
Labels
-compiler

Comments

@hubertp
Copy link
Collaborator

hubertp commented Mar 18, 2025

Currently, JVM mode can only be enabled globally via --jvm argument when starting Enso.
We need a more fine-grained per-project solution.

Ideally package.yaml would contain an entry like:

    jvm: true
@hubertp
Copy link
Collaborator Author

hubertp commented Mar 18, 2025

While here, we could potentially add JVM/VM options per-project.

@hubertp hubertp mentioned this issue Mar 19, 2025
Merged
5 tasks
@enso-bot
Copy link

enso-bot bot commented Mar 23, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-19):

Progress: Enabled per-project JVM configuration in package.yaml. #11609 needed verification, but can't reproduce anymore. Closed as the issue appears to have been resolved. It should be finished by 2025-03-19.

Next Day: Next day I will be working on the #12529 task. Investigate flaky tests on CI.

@hubertp hubertp moved this from ❓New to 👁️ Code review in Issues Board Mar 24, 2025
@mergify mergify bot closed this as completed in #12550 Mar 25, 2025
mergify bot pushed a commit that referenced this issue Mar 25, 2025
@hubertp
Enabled per-project JVM mode configuration (#12550)
5e4ea6f 
`package.yaml` now supports `jvm` field that takes a Boolean. If set to true, the project will be run in JVM mode even if Language Server's Native Image is available.
Also fixes a bug in runner when detecting JDK from JAVA_HOME on Windows.
Closes #12529.
@github-project-automation github-project-automation bot moved this from 👁️ Code review to 🟢 Accepted in Issues Board Mar 25, 2025
farmaazon pushed a commit that referenced this issue Mar 26, 2025
@hubertp @farmaazon
Enabled per-project JVM mode configuration (#12550)
08ff051 
`package.yaml` now supports `jvm` field that takes a Boolean. If set to true, the project will be run in JVM mode even if Language Server's Native Image is available.
Also fixes a bug in runner when detecting JDK from JAVA_HOME on Windows.
Closes #12529.
@enso-bot
Copy link

enso-bot bot commented Mar 30, 2025

Hubert Plociniczak reports a new STANDUP for the provided date (2025-03-25):

Progress: (Previous day reported under a wrong ticket). Merged a fix for #12529 after addressing all comments and fighting CI. Still fighting with #11576. Debugging random nightlies failures. Did some performance analysis for NI in Windows (#12407). It should be finished by 2025-03-25.

Next Day: Next day I will be working on the #12529 task. Pick up next item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hubertp hubertp

Labels
-compiler
Projects
Issues Board
Status: 🟢 Accepted
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Enabled per-project JVM mode configuration enso-org/enso
1 participant
@hubertp