Skip to content

Commit

Permalink
Add git submodule for dev-env repository. (#12264)
Browse files Browse the repository at this point in the history
To simplify every our dev's experience, this PR adds the repository with necessary configuration to a submodule, and adds proper symlinks so they will be automatically picked by vite.

The only step is initializing the submodule:
```
$ git submodule update --init
```

Anyone without permission to the dev-env repo will get `Permission denied` error to above command.

Additionally, removed the most jarringly wrong information from our CONTRIBUTING.md. This is not end of updating docs, however.
  • Loading branch information
farmaazon authored Feb 13, 2025
1 parent 595e0a8 commit 123126f
Show file tree
Hide file tree
Showing 20 changed files with 21 additions and 85 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/bazel-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:
with:
bazelisk-cache: true
bazelrc: build --remote_cache=grpcs://${{ vars.ENSO_BAZEL_CACHE_URI }} --remote_cache_header="authorization=Basic ${{ secrets.ENSO_BAZEL_CACHE_TOKEN }}"
- uses: actions/checkout@v4
- uses: submodules
- name: Expose env variables
run: |
cat << END > app/gui/.env.production
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/changelog.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/engine-benchmark.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
15 changes: 0 additions & 15 deletions .github/workflows/engine-checks-nightly.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -87,7 +86,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -136,7 +134,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -186,7 +183,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -236,7 +232,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -286,7 +281,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -348,7 +342,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -408,7 +401,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -469,7 +461,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -530,7 +521,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -591,7 +581,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -656,7 +645,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -719,7 +707,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -783,7 +770,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -847,7 +833,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/engine-checks-optional.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -88,7 +87,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -149,7 +147,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
8 changes: 0 additions & 8 deletions .github/workflows/engine-checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -88,7 +87,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -138,7 +136,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -199,7 +196,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -260,7 +256,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- name: Build Script Setup
run: ./run --help || (git clean -ffdx && ./run --help)
env:
Expand Down Expand Up @@ -301,7 +296,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -365,7 +359,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -429,7 +422,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/extra-nightly-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -107,7 +106,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/ide-packaging-optional.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -95,7 +94,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -158,7 +156,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
6 changes: 0 additions & 6 deletions .github/workflows/ide-packaging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -105,7 +104,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -162,7 +160,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -228,7 +225,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -291,7 +287,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down Expand Up @@ -384,7 +379,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/promote.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ jobs:
uses: actions/checkout@v4
with:
clean: false
submodules: recursive
- if: runner.os == 'macOS'
name: Setup nodejs version
uses: actions/setup-node@v4
Expand Down
Loading

0 comments on commit 123126f

Please sign in to comment.