VueJS SPA #2
Merged
VueJS SPA #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was causing huge performance overhead.
This reverts commit 3b4a45a.
- Copy cache dir inside dist - Update URLs to point to the served repo - MIN_DATE is a global constant
# Conflicts: # engine-benchs.html # stdlib-benchs.html
| import { useDataPointStore } from '../stores/dataPointsStore' | ||
| import { useLabelStore } from '../stores/labelStore' | ||
|
|
||
| export interface Commit { |
There was a problem hiding this comment.
These interfaces seem to describe the structure of JSON files that are being loaded in. How are they connected to the schema definitions? Why do we have TypeScript definition and also JSON schema definition?
Having two independent definition is good only for one thing: to make them inconsistent.
There was a problem hiding this comment.
Let's deal with this schema-related issues once we tackle the new data in enso-org/enso#10224
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes enso-org/enso#10212
Replaces the statically generated web pages by a VueJS single-page-application.
Docs in README.md.
Currently testing the deployment in the forked repo https://github.com/Akirathan/engine-benchmark-results