create addr only dnssec compatible resolver #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix controller event
import IMetadataService
Update deploy scripts in preparation for testnet deploy
Feature/Allow signed messages to claim reverse nodes
Fix/UniversalResolver miscellaneous bugs
mdtanrikulu
changed the title
Arachnid
reviewed
Aug 7, 2023
| ) { | ||
| if (selector == IAddressResolver.addr.selector) { | ||
| (, uint256 coinType) = abi.decode(data[4:], (bytes32, uint256)); | ||
| if (coinType != COIN_TYPE_ETH) return abi.encode(address(0)); |
There was a problem hiding this comment.
This should return a 0-length string, not a string of zeroes.
Arachnid
approved these changes
Aug 10, 2023
mdtanrikulu
changed the base branch from
c4-ens-audit-mitigations-2023-04
to
staging
|
closing this branch, since we cherry picked all to #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.