forked from sagemath/sage
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More information on fundamental groups of plane curves #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ta_group as its method
enriqueartal
changed the title
Arrangements
More information on fundamental groups of plane curves
Nov 25, 2023
Documentation preview for this PR (built with commit 483aa6c; changes) is ready! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to add some features to the computation of fundamental groups of complements of the plane curves introduced in
Sagemath
by @miguelmarco and his optional packagesirocco
. It also corrects a bug introduced in sagemath#35376 and cleans some code.We add the following information: given a tuple of curves we retrieve the information of meridians of each curve as words in the fundamental group, and also of the strands of the braid monodromy. We also add the possibility of excluding the vertical lines from the computation of braid monodromy (as far as there is no vertical asymptote) which makes its computation faster.
To achieve this goal we introduce new classes
AffinePlaneCurveArrangements
andProjectivePlaneCurveArrangements
. For now, they serve only to compute the fundamental groups with the meridian information (and braid monodromy and strand information for the affine curves) but more methods may be constructed in the future. The structure of these classes follows the one ofHyperplaneArrangements
, with one difference, the order is important. This is why we also introduce the class ofOrderedHyperplaneArrangements
, where the fundamental group is computed. We have also introduce a new method for hyperplane arrangements,jhyperplane_section
, in order to compute the fundamental group also for hyperplane arrangements and not only for line arrangements.These are the main changes:
has_vertical_asymptote
,is_vertical_line
fundamental_group
fundamental_group
.braid_in_segment
, correction of the bug introduced in the previous PR (the parameters must be in the number field embedded inQQbar
).geometric_basis
has been changed for designed and to cover some cases where the former one failed.vertical_lines_in_braidmon
to isolate vertical lines if needed.braid_monodromy
has been cleaned and now it takes into account the strand information.OrderedHyperplaneArrangements
. The hyperplanes are not sorted in this class and the introduction order is respected. It forces to update some methods.hyperplane_section
,affine_fundamental_group
,affine_meridians
,projective_fundamental_group
, andprojective_meridians
.📝 Checklist
⌛ Dependencies