Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replicate Personas #282 #287

Merged
merged 2 commits into from
Dec 21, 2023
Merged

Conversation

joriskalz
Copy link
Contributor

@joriskalz joriskalz commented Dec 20, 2023

This feature addresses the need for a more versatile persona creation process as outlined in issue #282. By allowing direct text input, users can quickly and efficiently replicate personas based on a wide range of textual sources.

Changes made:
Implemented a tabbed interface in YTPersonaCreator.tsx to allow users to choose between creating a persona from a YouTube video or from pasted text.

  • YTPersonaCreator.tsx: Added imports for tab components, implemented tabbed interface, and added text input handling.
  • Updated button states to ensure the 'Create' button is only active when there is input text or a valid YouTube URL.
  • PersonaSelector.tsx: Title changed to reflect both use cases.

Looking forward to feedback and suggestions for further refinement.

Screenshots:
Persona

Copy link

vercel bot commented Dec 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
big-agi ✅ Ready (Inspect) Visit Preview Dec 20, 2023 9:29pm

@enricoros
Copy link
Owner

enricoros commented Dec 21, 2023

Thanks @joriskalz your implementation is absolutely excellent!
To celebrate, I will:

  • style cleanup using the <TextArea instead of <textarea :D
  • rename YTPersonaCreator -> YTCreator
  • remove the "Labs" option, and show this by default
  • merge

Do you think we should default to the YouTube tab, or to the Text tab?

@enricoros enricoros mentioned this pull request Dec 21, 2023
2 tasks
@enricoros enricoros merged commit 44da928 into enricoros:main Dec 21, 2023
1 check passed
@enricoros
Copy link
Owner

enricoros commented Dec 21, 2023

Thanks @joriskalz - merged, promoted from experimental to stable, and cleaned up some of my code while at that.
Very well done!

  1. Do you think we should default to the YouTube tab, or to the Text tab?
  2. See Persona Creator: From Text #282 for more ideas - e.g. build a persona from Tweets, or Web Page, if interested.

@enricoros enricoros added this to the 1.9.0 milestone Dec 21, 2023
@joriskalz joriskalz deleted the Persona-From-Text branch December 21, 2023 15:38
@joriskalz
Copy link
Contributor Author

  1. Do you think we should default to the YouTube tab, or to the Text tab?

Thank you for the feedback. I agree that the current implementation is functioning very well and looks great. Regarding the default tab, I believe it might be beneficial to present the YouTube tab first. The YouTube integration showcases a more dynamic and interactive feature that could immediately capture users' interest with its visual appeal.

@enricoros
Copy link
Owner

@joriskalz sounds great. What app did you use to create this beautiful video? I would love to show more of the app features (voice calling, continuous text, diagrams, etc..) using short 15 seconds videos like that.

@joriskalz
Copy link
Contributor Author

@enricoros, i was using Screen Studio.

@enricoros enricoros mentioned this pull request Dec 28, 2023
22 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants