Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix (build): make devenv work on older debian #512

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lbovet
Copy link
Contributor

@lbovet lbovet commented Feb 19, 2024

Relates to | Fixes #<issue_number_goes_here>

It's a good idea to open an issue first for discussion.

  • ./test.bash passes locally
  • Appropriate changes to documentation are included in the PR

Copy link

google-cla bot commented Feb 19, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@vorburger
Copy link
Member

@lbovet do you have access to (can you see?) the build failure log? shellcheck doesn't like the script... do you want to fix that?

I suspect that if you fix that, then the CI build will pass... which is very wrong - because we know that this doesn't actually work (as-is), just.

#458 to me seems to be a pre-requisite to merge this - we need to FIRST test the DevEnv as-is on CI, to then improve it with this PR.

@lbovet
Copy link
Contributor Author

lbovet commented Feb 20, 2024

I admit I am a bit lost with all these PR open...

@vorburger vorburger added the build Build, CI, etc. (w.o. #testing) label Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build, CI, etc. (w.o. #testing)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants