Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add return type "int" to SecurityCheckerCommand #34

Merged
merged 2 commits into from
Dec 10, 2023
Merged

Add return type "int" to SecurityCheckerCommand #34

merged 2 commits into from
Dec 10, 2023

Conversation

tobias47n9e
Copy link
Contributor

@tobias47n9e tobias47n9e commented Nov 30, 2023 •
edited
Loading

Closes #33

@paras-malhotra
Copy link
Member

paras-malhotra commented Nov 30, 2023 •
edited
Loading

Thanks @tobias47n9e. I think this will break in lower versions of PHP. We would need to release a v2 with a different composer.json (limited to higher versions of PHP and Symfony). Could you perhaps update this PR with changes to composer.json?

@tobias47n9e
Copy link
Contributor Author

@paras-malhotra I added the changes

@tobias47n9e
Copy link
Contributor Author

@paras-malhotra Do you have time to review this?

@paras-malhotra paras-malhotra merged commit 480994e into enlightn:main Dec 10, 2023
1 check failed
@paras-malhotra paras-malhotra added the chore Chore or maintenance task/issue label Dec 10, 2023
@paras-malhotra
Copy link
Member

Thanks @tobias47n9e, this is now available in v2.0.0

@tobias47n9e
Copy link
Contributor Author

@paras-malhotra Thanks 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore Chore or maintenance task/issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incompatibility with newest Symfony Console version
2 participants
@tobias47n9e @paras-malhotra