stable avalon frontend #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…other LiteX/LiteDRAM modules.
…r cmd. To better decouple cmd/data paths in user logic.
…d with LiteDRAMNativePortConverter improvement).
hansfbaier
changed the title
|
Hi @hansfbaier, Sorry for the delay, this is merged, thanks for the test/feedback and re-combining the commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had the following issue with current master in MiSTeX:
The sdram usually initializes correctly, and often ran well for up to ten minutes or so,
but then the Screen (which outputs the framebuffer of a scaler) would go dark,
or show a regular garbage pattern.
As long as the screen output was good, sdram_test would pass on the LiteX BIOS console.
But as soon the screen output was corrupt, sdram_test also would fail on the LiteX BIOS console.
Doing a reset fixed the screen output again, with sdram_test passing again for a couple of minutes,
but then it would become corrupt again. The timeframe this would happen
ranges from instantly after core load to more than ten minutes.
This revision not only has a much cleaner code base,
but also now ran without issues for 6 hours.
Since this PR is made up entirely of your own commits, review should not be difficult.
Is there anything which would speak against merging this into master?