Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CheckBox drawing update #269

Merged
merged 2 commits into from
Aug 27, 2022
Merged

CheckBox drawing update #269

merged 2 commits into from
Aug 27, 2022

Conversation

enisn
Copy link
Owner

@enisn enisn commented Aug 27, 2022

Feature

  • Checkbox is now using Paths to render itself. So UWP - Windows is supported.
    image

  • Following types are added: Line

image

  • Custom images should be passed as SVG
    <input:CheckBox Text="Option 4 with Custom Type (X)" Type="Custom" CustomIconGeometry="M17.705 7.705l-1.41-1.41L12 10.59 7.705 6.295l-1.41 1.41L10.59 12l-4.295 4.295 1.41 1.41L12 13.41l4.295 4.295 1.41-1.41L13.41 12l4.295-4.295z"/>
    image

Breaking change

Following components has breaking change

Checkbox

  • No longer images are used.
  • Custom type isn't supported anymore (at least as image)
  • Following types are removed Star, Cross
  • Default type is Check from now. (If you don't define the type and use box variation, you have to define type withType="Box")

@enisn enisn added platform-windows UWP Support or feature feature A new feature platform-android Something related with Android platform-ios Something related with iOS target-MAUI platform-maccatalyst breaking-change labels Aug 27, 2022
@enisn enisn added this to the v.4.0.0 milestone Aug 27, 2022
@enisn enisn marked this pull request as ready for review August 27, 2022 21:56
@enisn enisn changed the title Use drawing for Checkbox CheckBox drawing update Aug 27, 2022
@enisn enisn merged commit 2edd311 into develop Aug 27, 2022
@enisn enisn deleted the checkbox-improvements branch August 27, 2022 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking-change feature A new feature platform-android Something related with Android platform-ios Something related with iOS platform-maccatalyst platform-windows UWP Support or feature target-MAUI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant