Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New Feature]Add labelposition to radiobutton and checkbox #111

Merged
merged 5 commits into from
Apr 3, 2019
Merged

[New Feature]Add labelposition to radiobutton and checkbox #111

merged 5 commits into from
Apr 3, 2019

Conversation

hongyue
Copy link
Contributor

@hongyue hongyue commented Apr 2, 2019

add LabelPosition property to RadioButton and CheckBox controls, so we can specify the label's position (after or before).

enisn
enisn reviewed Apr 2, 2019
View reviewed changes
Copy link
Owner

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's looking perfect!
Thank you that awesome feature!

enisn
enisn reviewed Apr 2, 2019
View reviewed changes
Copy link
Owner

@enisn enisn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hongyue
What happens if I set FlowDirection as RightToLeft ?

Old version was working perfect with RightToLeft version.
Right now it should behave reversed with RightToLeft state.

@enisn enisn added the enhancement New feature or request label Apr 2, 2019
@enisn enisn mentioned this pull request Apr 2, 2019
Closed
@hongyue
Copy link
Contributor Author

hongyue commented Apr 3, 2019

Never used that property, not count it in, I'll take some time to try to fix it.

@hongyue
add LabelPosition property to SelectionView; bug fixed: double tap on…
e364754 
… the same radio button causes radio button deselected in SelectionView.
@hongyue
Copy link
Contributor Author

hongyue commented Apr 3, 2019

@enisn I just checked it, it looks like the behavior is correct. Did you mean the naming is inappropriate of LabelPosition's members (Before, After)? In right-to-left language, right is not before? Not quite understand that.

@enisn
Copy link
Owner

enisn commented Apr 3, 2019

@enisn I just checked it, it looks like the behavior is correct. Did you mean the naming is inappropriate of LabelPosition's members (Before, After)? In right-to-left language, right is not before? Not quite understand that.

Yeah, When I think like that, naming comes right, too for RigtToLeft languages. I'm merging it. Thanks for your contribution @hongyue 👍

@enisn enisn merged commit d32877b into enisn:master Apr 3, 2019
@enisn
Copy link
Owner

enisn commented Apr 3, 2019

@hongyue
I'm just making some other improvements with your feature. It'll be released at v3.0.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@enisn enisn enisn left review comments

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hongyue @enisn