Skip to content

Commit

Permalink
Only run dart files as a test in the Android preview tools test shard…
Browse files Browse the repository at this point in the history
… (#140099)

I added a README at the end of flutter/flutter#131901 and did not realize that it was being run as a test, [leading to test failures (of course)](https://logs.chromium.org/logs/flutter/buildbucket/cr-buildbucket/8761789207346423409/+/u/run_test.dart_for_android_preview_tool_integration_tests_shard_and_subshard_None/test_stdout). This makes it so we only run dart files as dart tests.
  • Loading branch information
gmackall authored Dec 18, 2023
1 parent a17e2e0 commit bdfb56c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion dev/bots/test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -482,7 +482,7 @@ Future<void> _runAndroidPreviewIntegrationToolTests() async {
final List<String> allTests = Directory(path.join(_toolsPath, 'test', 'android_preview_integration.shard'))
.listSync(recursive: true).whereType<File>()
.map<String>((FileSystemEntity entry) => path.relative(entry.path, from: _toolsPath))
.toList();
.where((String testPath) => path.basename(testPath).endsWith('_test.dart')).toList();

await _runDartTest(
_toolsPath,
Expand Down

0 comments on commit bdfb56c

Please sign in to comment.