Skip to content

Commit

Permalink
Move analysis test to shard tests. (#139161)
Browse files Browse the repository at this point in the history
This is part of the effort to deprecated adhoc tests.

Bug: flutter/flutter#139153
  • Loading branch information
godofredoc authored Nov 28, 2023
1 parent a49ee53 commit 8b6277e
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 10 deletions.
14 changes: 6 additions & 8 deletions .ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -242,13 +242,12 @@ platform_properties:

targets:
- name: Linux analyze
recipe: flutter/flutter
recipe: flutter/flutter_drone
timeout: 60
properties:
shard: analyze
tags: >
["framework","hostonly","linux"]
validation: analyze
validation_name: Analyze
["framework","hostonly","shard","linux"]
- name: Linux analyzer_benchmark
recipe: devicelab/devicelab_drone
Expand Down Expand Up @@ -2948,14 +2947,13 @@ targets:
- name: Staging_build_linux analyze
presubmit: false
bringup: true
recipe: flutter/flutter
recipe: flutter/flutter_drone
timeout: 60
properties:
shard: analyze
ignore_flakiness: "true"
tags: >
["framework","hostonly","linux"]
validation: analyze
validation_name: Analyze
["framework","hostonly","shard","linux"]
- name: Mac_benchmark animated_complex_opacity_perf_macos__e2e_summary
presubmit: false
Expand Down
3 changes: 1 addition & 2 deletions TESTOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -295,8 +295,6 @@
/dev/devicelab/bin/tasks/windows_startup_test.dart @loic-sharma @flutter/desktop

## Host only framework tests
# Linux analyze
/dev/bots/analyze.dart @HansMuller @flutter/framework
# Linux docs
# Linux docs_test
# Linux docs_publish
Expand All @@ -321,6 +319,7 @@
# TODO(keyonghan): add files/paths for below framework host only testss.
# https://github.com/flutter/flutter/issues/82068
#
# analyze @HansMuller @flutter/framework
# build_tests @eliasyishak @flutter/tool
# ci_yaml flutter roller @caseyhillers @flutter/infra
# coverage @godofredoc @flutter/infra
Expand Down
14 changes: 14 additions & 0 deletions dev/bots/test.dart
Original file line number Diff line number Diff line change
Expand Up @@ -264,6 +264,7 @@ Future<void> main(List<String> args) async {
'skp_generator': _runSkpGeneratorTests,
'realm_checker': _runRealmCheckerTest,
'customer_testing': _runCustomerTesting,
'analyze': _runAnalyze,
kTestHarnessShardName: _runTestHarnessTests, // Used for testing this script; also run as part of SHARD=framework_tests, SUBSHARD=misc.
});
} catch (error, stackTrace) {
Expand Down Expand Up @@ -1588,6 +1589,19 @@ Future<void> _runCustomerTesting() async {
);
}

// Runs analysis tests.
Future<void> _runAnalyze() async {
printProgress('${green}Running analysis testing$reset');
await runCommand(
'dart',
<String>[
'--enable-asserts',
path.join(flutterRoot, 'dev', 'bots', 'analyze.dart'),
],
workingDirectory: flutterRoot,
);
}

/// Runs the skp_generator from the flutter/tests repo.
///
/// See also the customer_tests shard.
Expand Down

0 comments on commit 8b6277e

Please sign in to comment.