Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the warnings #15

Merged
merged 1 commit into from
Feb 8, 2018

Conversation

narek-h
Copy link
Contributor

@narek-h narek-h commented Jan 20, 2018

Summary of changes

  1. validateNewState now returns the result which was set but not returned. Now the returned value is not used but can be useful later.
  2. in this.setState({...}, this.validateNewState()); calls validateNewState() changed to validateNewState since it's expecting a callback.
    (there was no error on that since the method call result was 'undefined')
  3. To avoid no-func-assign warnings in places
 function foo() {}
 foo = foo.bind(this);

function declarations were replaced with function expressions

var foo = function () {}
  1. in a couple of places == -> === , and removed unused let props = this.props;

@narek-h
Copy link
Contributor Author

narek-h commented Jan 20, 2018

@RyanLucchese RyanLucchese merged commit bf20aa9 into energicryptocurrency:develop Feb 8, 2018
@RyanLucchese RyanLucchese mentioned this pull request Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants