Blacklist properties we expect to remove #614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entering these properties into whitelist.js with a
falsesetting, like omitting them, causes them to be removed. But listing them explicitly records that we're not surprised by seeing them, solockdownremoves them silently. If we see a property that does not appear on the whitelist at all,lockdownlogs a record of that so we can react to the surprise. #612 nicely demonstrates how useful that feedback is.This PR is a result of testing https://ses-demo.netlify.app/demos/console/ on a variety of browsers, plus recording what we already know about XS. Because I am on a Mac, I have not tested Edge. If someone could and post the console output, that would be appreciated.