-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ses): dont use native harden #2677
Draft
erights
wants to merge
3
commits into
master
Choose a base branch
from
markm-dont-use-native-harden
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
erights
force-pushed
the
markm-use-no-trapping-shim
branch
7 times, most recently
from
January 3, 2025 19:55
60157c5
to
82e1233
Compare
erights
force-pushed
the
markm-dont-use-native-harden
branch
from
January 3, 2025 19:59
cf7676f
to
528a9c4
Compare
erights
force-pushed
the
markm-dont-use-native-harden
branch
from
January 3, 2025 20:10
528a9c4
to
2907df1
Compare
erights
force-pushed
the
markm-dont-use-native-harden
branch
from
January 18, 2025 02:51
e08b084
to
88b13ad
Compare
erights
force-pushed
the
markm-dont-use-native-harden
branch
from
January 25, 2025 20:17
88b13ad
to
da4a309
Compare
erights
added a commit
that referenced
this pull request
Jan 25, 2025
erights
added a commit
that referenced
this pull request
Jan 27, 2025
erights
added a commit
that referenced
this pull request
Jan 27, 2025
erights
added a commit
that referenced
this pull request
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was staged on #2675 , but changed to standalone to isolate problems.
Closes: #XXXX
Refs: #XXXX
Description
Old: Differs from #2675 only in that is doesn't use the native hardener if there, and therefore not on XS, because that one does not (yet?) support suppressTrapping.
This is expected to be too expensive for production, so currently this PR is only to see what breaks under CI, and why.
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Compatibility Considerations
Upgrade Considerations